From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.42.229.71 with SMTP id jh7cs94579icb; Tue, 25 Jan 2011 13:44:02 -0800 (PST) Received: by 10.224.2.76 with SMTP id 12mr5828679qai.89.1295991841891; Tue, 25 Jan 2011 13:44:01 -0800 (PST) Return-Path: Received: from rubyforge.org (rubyforge.org [205.234.109.19]) by mx.google.com with ESMTP id my6si31099120qcb.38.2011.01.25.13.44.01; Tue, 25 Jan 2011 13:44:01 -0800 (PST) Received-SPF: pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19; Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-devel-bounces@rubyforge.org Received: from rubyforge.org (rubyforge.org [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id 3E8AF18582EE; Tue, 25 Jan 2011 16:44:01 -0500 (EST) Received: from kuovi.tilus.net (kuovi.tilus.net [80.68.89.168]) by rubyforge.org (Postfix) with ESMTP id 293631858357 for ; Tue, 25 Jan 2011 16:25:03 -0500 (EST) Received: by kuovi.tilus.net (Postfix, from userid 1000) id 39ECE6088; Tue, 25 Jan 2011 23:25:03 +0200 (EET) From: Tero Tilus To: Sup developers In-reply-to: <1295979620-sup-7844@alvh.no-ip.org> References: <1295911516-sup-1253@tilus.net> <1295979620-sup-7844@alvh.no-ip.org> Date: Tue, 25 Jan 2011 23:25:03 +0200 Message-Id: <1295990180-sup-2106@tilus.net> User-Agent: Sup/git Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-1295990703-209224-8066-3013-1-=" Subject: Re: [sup-devel] Patch: Always try to canonize person name using ContactManager X-BeenThere: sup-devel@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Sup developer discussion List-Id: Sup developer discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: sup-devel-bounces@rubyforge.org Errors-To: sup-devel-bounces@rubyforge.org --=-1295990703-209224-8066-3013-1-= Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Alvaro Herrera, 2011-01-25 20:29: > One minor nit, probably material for another patch: the list of > names that's built in the thread index mode doesn't seem to use this > facility When message was built from index it bypassed person canonization. Amended patch attached. > and so when you have a thread that includes several emails from the > same account but inconsistent names, that person is listed more than > once in the "participants" column, with the different names. > > (For example I have a thread from Fabian, Fabián, and > fabian.martinez that all come from the same > fabian.martinez@example.com account). Actually, this was completely independent of the person canonization feature. Thread index mode, when constructing the from-list, identified authors by name, not by email. The people not in contacts.txt and appearing in from fields with varying names were listed several times. Attached patch also fixes this. -- Tero Tilus ## 050 3635 235 ## http://tero.tilus.net/ --=-1295990703-209224-8066-3013-1-= Content-Disposition: attachment; filename="0002-Always-try-to-canonize-person-using-ContactManager.patch" Content-Type: application/octet-stream; name="0002-Always-try-to-canonize-person-using-ContactManager.patch" Content-Transfer-Encoding: base64 RnJvbSBiNmFmYzU1Y2QwNTM5YTM4ZWYxNmI2MmMyMDYxODFlZjI5N2M5OGRm IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBUZXJvIFRpbHVzIDx0 ZXJvQHRpbHVzLm5ldD4KRGF0ZTogVHVlLCAyNSBKYW4gMjAxMSAwMToxMjoz MCArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIEFsd2F5cyB0cnkgdG8gY2Fub25p emUgcGVyc29uIHVzaW5nIENvbnRhY3RNYW5hZ2VyCgpTaWduZWQtb2ZmLWJ5 OiBUZXJvIFRpbHVzIDx0ZXJvQHRpbHVzLm5ldD4KLS0tCiBsaWIvc3VwL2Nv bnRhY3QucmIgICAgICAgICAgICAgICAgIHwgICAxMyArKysrKysrKystLS0t CiBsaWIvc3VwL2luZGV4LnJiICAgICAgICAgICAgICAgICAgIHwgICAgNiAr KysrLS0KIGxpYi9zdXAvbW9kZXMvdGhyZWFkLWluZGV4LW1vZGUucmIgfCAg ICA0ICsrLS0KIGxpYi9zdXAvcGVyc29uLnJiICAgICAgICAgICAgICAgICAg fCAgICA4ICsrKysrKystCiA0IGZpbGVzIGNoYW5nZWQsIDIyIGluc2VydGlv bnMoKyksIDkgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGliL3N1cC9j b250YWN0LnJiIGIvbGliL3N1cC9jb250YWN0LnJiCmluZGV4IGM0ODlhYWYu LjM4Mjg5NmQgMTAwNjQ0Ci0tLSBhL2xpYi9zdXAvY29udGFjdC5yYgorKysg Yi9saWIvc3VwL2NvbnRhY3QucmIKQEAgLTEyLDE0ICsxMiwxMyBAQCBjbGFz cyBDb250YWN0TWFuYWdlcgogCiAgICAgQHAyYSA9IHt9ICMgcGVyc29uIHRv IGFsaWFzCiAgICAgQGEycCA9IHt9ICMgYWxpYXMgdG8gcGVyc29uCisgICAg QGUycCA9IHt9ICMgZW1haWwgdG8gcGVyc29uCiAKICAgICBpZiBGaWxlLmV4 aXN0cz8gZm4KICAgICAgIElPLmZvcmVhY2goZm4pIGRvIHxsfAogICAgICAg ICBsID1+IC9eKFteOl0qKTogKC4qKSQvIG9yIHJhaXNlICJjYW4ndCBwYXJz ZSAje2ZufSBsaW5lICN7bC5pbnNwZWN0fSIKICAgICAgICAgYWFsaWFzLCBh ZGRyID0gJDEsICQyCi0gICAgICAgIHAgPSBQZXJzb24uZnJvbV9hZGRyZXNz IGFkZHIKLSAgICAgICAgQHAyYVtwXSA9IGFhbGlhcwotICAgICAgICBAYTJw W2FhbGlhc10gPSBwIHVubGVzcyBhYWxpYXMubmlsPyB8fCBhYWxpYXMuZW1w dHk/CisgICAgICAgIHVwZGF0ZV9hbGlhcyBQZXJzb24uZnJvbV9hZGRyZXNz KGFkZHIpLCBhYWxpYXMKICAgICAgIGVuZAogICAgIGVuZAogICBlbmQKQEAg LTMwLDkgKzI5LDEzIEBAIGNsYXNzIENvbnRhY3RNYW5hZ2VyCiAgIGRlZiB1 cGRhdGVfYWxpYXMgcGVyc29uLCBhYWxpYXM9bmlsCiAgICAgaWYob2xkX2Fh bGlhcyA9IEBwMmFbcGVyc29uXSkgIyByZW1vdmUgb2xkIGFsaWFzCiAgICAg ICBAYTJwLmRlbGV0ZSBvbGRfYWFsaWFzCisgICAgICBAZTJwLmRlbGV0ZSBv bGRfYWFsaWFzLmVtYWlsCiAgICAgZW5kCiAgICAgQHAyYVtwZXJzb25dID0g YWFsaWFzCi0gICAgQGEycFthYWxpYXNdID0gcGVyc29uIHVubGVzcyBhYWxp YXMubmlsPyB8fCBhYWxpYXMuZW1wdHk/CisgICAgdW5sZXNzIGFhbGlhcy5u aWw/IHx8IGFhbGlhcy5lbXB0eT8KKyAgICAgIEBhMnBbYWFsaWFzXSA9IHBl cnNvbgorICAgICAgQGUycFtwZXJzb24uZW1haWxdID0gcGVyc29uCisgICAg ZW5kCiAgIGVuZAogCiAgICMjIHRoaXMgbWF5IG5vdCBhY3R1YWxseSBiZSBj YWxsZWQgYW55d2hlcmUsIHNpbmNlIHdlIHN0aWxsIGtlZXAgY29udGFjdHMK QEAgLTQwLDExICs0MywxMyBAQCBjbGFzcyBDb250YWN0TWFuYWdlcgogICBk ZWYgZHJvcF9jb250YWN0IHBlcnNvbgogICAgIGFhbGlhcyA9IEBwMmFbcGVy c29uXQogICAgIEBwMmEuZGVsZXRlIHBlcnNvbgorICAgIEBlMnAuZGVsZXRl IHBlcnNvbi5lbWFpbAogICAgIEBhMnAuZGVsZXRlIGFhbGlhcyBpZiBhYWxp YXMKICAgZW5kCiAKICAgZGVmIGNvbnRhY3RfZm9yIGFhbGlhczsgQGEycFth YWxpYXNdIGVuZAogICBkZWYgYWxpYXNfZm9yIHBlcnNvbjsgQHAyYVtwZXJz b25dIGVuZAorICBkZWYgcGVyc29uX2ZvciBlbWFpbDsgQGUycFtlbWFpbF0g ZW5kCiAgIGRlZiBpc19hbGlhc2VkX2NvbnRhY3Q/IHBlcnNvbjsgIUBwMmFb cGVyc29uXS5uaWw/IGVuZAogCiAgIGRlZiBzYXZlCmRpZmYgLS1naXQgYS9s aWIvc3VwL2luZGV4LnJiIGIvbGliL3N1cC9pbmRleC5yYgppbmRleCBiY2M0 NDliLi45NWYxMDRhIDEwMDY0NAotLS0gYS9saWIvc3VwL2luZGV4LnJiCisr KyBiL2xpYi9zdXAvaW5kZXgucmIKQEAgLTIxMCw3ICsyMTAsOSBAQCBFT1MK ICAgICAgICAgICAgICAgICAgICAgOmxhYmVscyA9PiBlbnRyeVs6bGFiZWxz XSwKICAgICAgICAgICAgICAgICAgICAgOnNuaXBwZXQgPT4gZW50cnlbOnNu aXBwZXRdCiAKLSAgICBta19wZXJzb24gPSBsYW1iZGEgeyB8eHwgUGVyc29u Lm5ldygqeC5yZXZlcnNlISkgfQorICAgICMgVHJ5IHRvIGZpbmQgcGVyc29u IGZyb20gY29udGFjdHMgYmVmb3JlIGZhbGxpbmcgYmFjayB0bworICAgICMg Z2VuZXJhdGluZyBpdCBmcm9tIHRoZSBhZGRyZXNzLgorICAgIG1rX3BlcnNv biA9IGxhbWJkYSB7IHx4fCBQZXJzb24uZnJvbV9uYW1lX2FuZF9lbWFpbCgq eC5yZXZlcnNlISkgfQogICAgIGVudHJ5Wzpmcm9tXSA9IG1rX3BlcnNvbltl bnRyeVs6ZnJvbV1dCiAgICAgZW50cnlbOnRvXS5tYXAhKCZta19wZXJzb24p CiAgICAgZW50cnlbOmNjXS5tYXAhKCZta19wZXJzb24pCkBAIC0yMzUsNyAr MjM3LDcgQEAgRU9TCiAgICAgICBtID0gYi5jYWxsCiAgICAgICAoW20uZnJv bV0rbS50byttLmNjK20uYmNjKS5jb21wYWN0LmVhY2ggeyB8cHwgY29udGFj dHMgPDwgW3AubmFtZSwgcC5lbWFpbF0gfQogICAgIGVuZAotICAgIGNvbnRh Y3RzLnRvX2EuY29tcGFjdC5tYXAgeyB8bixlfCBQZXJzb24ubmV3IG4sIGUg fVswLi4ubnVtXQorICAgIGNvbnRhY3RzLnRvX2EuY29tcGFjdFswLi4ubnVt XS5tYXAgeyB8bixlfCBQZXJzb24uZnJvbV9uYW1lX2FuZF9lbWFpbCBuLCBl IH0KICAgZW5kCiAKICAgIyMgWWllbGQgZWFjaCBtZXNzYWdlLWlkIG1hdGNo aW5nIHF1ZXJ5CmRpZmYgLS1naXQgYS9saWIvc3VwL21vZGVzL3RocmVhZC1p bmRleC1tb2RlLnJiIGIvbGliL3N1cC9tb2Rlcy90aHJlYWQtaW5kZXgtbW9k ZS5yYgppbmRleCAxMTU0OGM3Li4wNDBkZmE1IDEwMDY0NAotLS0gYS9saWIv c3VwL21vZGVzL3RocmVhZC1pbmRleC1tb2RlLnJiCisrKyBiL2xpYi9zdXAv bW9kZXMvdGhyZWFkLWluZGV4LW1vZGUucmIKQEAgLTc5Miw4ICs3OTIsOCBA QCBwcm90ZWN0ZWQKICAgICBhdXRob3JzID0gdC5tYXAgZG8gfG0sICpvfAog ICAgICAgbmV4dCB1bmxlc3MgbSAmJiBtLmZyb20KICAgICAgIG5ld1ttLmZy b21dIHx8PSBtLmhhc19sYWJlbD8oOnVucmVhZCkKLSAgICAgIG5leHQgaWYg c2VlblttLmZyb20ubWVkaXVtbmFtZV0KLSAgICAgIHNlZW5bbS5mcm9tLm1l ZGl1bW5hbWVdID0gdHJ1ZQorICAgICAgbmV4dCBpZiBzZWVuW20uZnJvbV0K KyAgICAgIHNlZW5bbS5mcm9tXSA9IHRydWUKICAgICAgIG0uZnJvbQogICAg IGVuZC5jb21wYWN0CiAKZGlmZiAtLWdpdCBhL2xpYi9zdXAvcGVyc29uLnJi IGIvbGliL3N1cC9wZXJzb24ucmIKaW5kZXggMjg4ODdiMy4uNDFhOWE5MCAx MDA2NDQKLS0tIGEvbGliL3N1cC9wZXJzb24ucmIKKysrIGIvbGliL3N1cC9w ZXJzb24ucmIKQEAgLTcxLDYgKzcxLDEyIEBAIGNsYXNzIFBlcnNvbgogICAg IGVuZC5kb3duY2FzZQogICBlbmQKIAorICAjIyByZXR1cm4gImNhbm9uaWNh bCIgcGVyc29uIHVzaW5nIGNvbnRhY3QgbWFuYWdlciBvciBjcmVhdGUgb25l IGlmCisgICMjIG5vdCBmb3VuZCBvciBjb250YWN0IG1hbmFnZXIgbm90IGF2 YWlsYWJsZQorICBkZWYgc2VsZi5mcm9tX25hbWVfYW5kX2VtYWlsIG5hbWUs IGVtYWlsCisgICAgQ29udGFjdE1hbmFnZXIuaW5zdGFudGlhdGVkPyAmJiBD b250YWN0TWFuYWdlci5wZXJzb25fZm9yKGVtYWlsKSB8fCBQZXJzb24ubmV3 KG5hbWUsIGVtYWlsKQorICBlbmQKKwogICBkZWYgc2VsZi5mcm9tX2FkZHJl c3MgcwogICAgIHJldHVybiBuaWwgaWYgcy5uaWw/CiAKQEAgLTEwMCw3ICsx MDYsNyBAQCBjbGFzcyBQZXJzb24KICAgICAgICAgW25pbCwgc10KICAgICAg IGVuZAogCi0gICAgUGVyc29uLm5ldyBuYW1lLCBlbWFpbAorICAgIGZyb21f bmFtZV9hbmRfZW1haWwgbmFtZSwgZW1haWwKICAgZW5kCiAKICAgZGVmIHNl bGYuZnJvbV9hZGRyZXNzX2xpc3Qgc3MKLS0gCjEuNS42LjUKCg== --=-1295990703-209224-8066-3013-1-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel --=-1295990703-209224-8066-3013-1-=--