From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: sup-devel <sup-devel@rubyforge.org>
Subject: Re: [sup-devel] Patch: Always try to canonize person name using ContactManager
Date: Tue, 25 Jan 2011 15:29:39 -0300 [thread overview]
Message-ID: <1295979620-sup-7844@alvh.no-ip.org> (raw)
In-Reply-To: <1295911516-sup-1253@tilus.net>
Excerpts from Tero Tilus's message of lun ene 24 20:33:23 -0300 2011:
> Sup has mostly not been using the names defined in contacts.txt when
> displaying messages. I vaguely remember seeing an issue reported on
> something similar to this. I became annoyed enough and fixed it.
>
> Now Person.from_address first tries to find the person using
> ContactManager (if it is instantiated) and falls back to
> Person.new(name, email).
I tried this patch -- works great, thanks.
One minor nit, probably material for another patch: the list of names
that's built in the thread index mode doesn't seem to use this
facility, and so when you have a thread that includes several emails
from the same account but inconsistent names, that person is listed more
than once in the "participants" column, with the different names.
(For example I have a thread from Fabian, Fabián, and fabian.martinez
that all come from the same fabian.martinez@example.com account).
--
Álvaro Herrera -- Se vende casa en Ñuñoa: www.portalinmobiliario.com/993147
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
next prev parent reply other threads:[~2011-01-25 18:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-24 23:33 Tero Tilus
2010-02-10 21:04 ` [sup-devel] Person.from_address and Contacts (or John.Smith@example.com) Gregor Hoffleit
2011-01-25 12:55 ` [sup-devel] Patch: Always try to canonize person name using ContactManager Gregor Hoffleit
2011-01-25 21:26 ` Tero Tilus
2011-01-25 18:29 ` Alvaro Herrera [this message]
2011-01-25 21:25 ` Tero Tilus
2011-06-20 22:43 ` Hamish Downer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295979620-sup-7844@alvh.no-ip.org \
--to=alvherre@alvh.no-ip.org \
--cc=sup-devel@rubyforge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox