From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.42.229.71 with SMTP id jh7cs76799icb; Tue, 25 Jan 2011 05:24:55 -0800 (PST) Received: by 10.229.99.76 with SMTP id t12mr4736904qcn.275.1295961894860; Tue, 25 Jan 2011 05:24:54 -0800 (PST) Return-Path: Received: from rubyforge.org (rubyforge.org [205.234.109.19]) by mx.google.com with ESMTP id k2si30100889qcu.12.2011.01.25.05.24.54; Tue, 25 Jan 2011 05:24:54 -0800 (PST) Received-SPF: pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19; Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-devel-bounces@rubyforge.org Received: from rubyforge.org (rubyforge.org [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id 393731678325; Tue, 25 Jan 2011 08:24:54 -0500 (EST) X-Greylist: delayed 514 seconds by postgrey-1.31 at rubyforge.org; Tue, 25 Jan 2011 08:03:58 EST Received: from sam.mediasupervision.de (sam.mediasupervision.de [80.152.3.104]) by rubyforge.org (Postfix) with ESMTP id D9084185838C for ; Tue, 25 Jan 2011 08:03:57 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by sam.mediasupervision.de (Postfix) with ESMTP id E9FF2485DF6 for ; Tue, 25 Jan 2011 13:55:17 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at sam.mediasupervision.de Received: from sam.mediasupervision.de ([127.0.0.1]) by localhost (sam.mediasupervision.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id p3QqoZbmcDYp for ; Tue, 25 Jan 2011 13:55:17 +0100 (CET) Received: by sam.mediasupervision.de (Postfix, from userid 1000) id 89510485DFC; Tue, 25 Jan 2011 13:55:17 +0100 (CET) From: Gregor Hoffleit To: sup-devel In-reply-to: <1295911516-sup-1253@tilus.net> References: <1295911516-sup-1253@tilus.net>, <1265828498-sup-6054@sam.mediasupervision.de> Date: Tue, 25 Jan 2011 13:55:17 +0100 Message-Id: <1295960019-sup-8840@sam.mediasupervision.de> User-Agent: Sup/git Subject: Re: [sup-devel] Patch: Always try to canonize person name using ContactManager X-BeenThere: sup-devel@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Sup developer discussion List-Id: Sup developer discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: sup-devel-bounces@rubyforge.org Errors-To: sup-devel-bounces@rubyforge.org * Tero Tilus [Di Jan 25 00:33:23 +0100 2011] > Sup has mostly not been using the names defined in contacts.txt when > displaying messages. I vaguely remember seeing an issue reported on > something similar to this. I became annoyed enough and fixed it. > > Now Person.from_address first tries to find the person using > ContactManager (if it is instantiated) and falls back to > Person.new(name, email). I guess you saw my report in <1265828498-sup-6054@sam.mediasupervision.de>: * Gregor Hoffleit [Mi Feb 10 22:04:57 +0100 2010] > I have quite a few contacts that send their mails without a display > name, i.e. something like "From: John.Smith@example.com". > > Sup does some magic (in Person.from_address) to derive something like a > display name from the local-part of the e-mail address. That's fine so > far. > > But, if the person is in my list of contacts, I want Sup to show the > display name definied in the contacts entry. In the above case, that > might be "John Smith" or "John E. Smith" or whatever. Instead, Sup > sticks to the display name derived from the local part, "john.smith". > > It's especially odd in the detailed header view of the thread-view-mode, > where Sup resolves and shows the alias, but still sticks to the derived > display name: > > From: john.smith (Johnny Boy) > > > The obvious place to start a fix would be Person.from_address, where > the (display) name, if missing, is derived from the email address. > > I wanted to modify Person.from_address in order to use, in the case of > an empty display name, the ContactManager, to look up any alias in the > contact list, but somehow I didn't succeed integrating ContactManager > in person.rb. > > Any better idea? Should I file a bug about this? Regards, Gregor Hoffleit _______________________________________________ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel