From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.42.229.71 with SMTP id jh7cs175116icb; Wed, 19 Jan 2011 08:49:03 -0800 (PST) Received: by 10.231.12.8 with SMTP id v8mr1090818ibv.147.1295455742690; Wed, 19 Jan 2011 08:49:02 -0800 (PST) Return-Path: Received: from rubyforge.org (rubyforge.org [205.234.109.19]) by mx.google.com with ESMTP id m14si8088285qcu.110.2011.01.19.08.49.02; Wed, 19 Jan 2011 08:49:02 -0800 (PST) Received-SPF: pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19; Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-devel-bounces@rubyforge.org Received: from rubyforge.org (rubyforge.org [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id 1E7E819782F8; Wed, 19 Jan 2011 11:49:02 -0500 (EST) Received: from smtp.chost.de (setoy.chost.de [217.160.209.225]) by rubyforge.org (Postfix) with ESMTP id 1F1081858361 for ; Wed, 19 Jan 2011 11:46:41 -0500 (EST) Received: (qmail 26470 invoked by uid 5015); 19 Jan 2011 16:46:48 -0000 Received: (nullmailer pid 11254 invoked by uid 123); Wed, 19 Jan 2011 16:46:40 -0000 Received: from twin.sascha.silbe.org (twin.sascha.silbe.org [192.168.1.2]) by flatty.sascha.silbe.org ([192.168.1.252]) with SMTP via TCP; 19 Jan 2011 16:46:40 -0000 Received: (nullmailer pid 8447 invoked by uid 8193); Wed, 19 Jan 2011 16:42:32 -0000 To: William Morgan Mail-followup-to: William Morgan , sup-devel In-reply-to: <1295451265-sup-1883@masanjin.net> References: <1295375324-2496-1-git-send-email-sascha-pgp@silbe.org> <1295375324-2496-2-git-send-email-sascha-pgp@silbe.org> <1295451265-sup-1883@masanjin.net> Date: Wed, 19 Jan 2011 17:42:28 +0100 Message-Id: <1295454858-sup-1718@twin.sascha.silbe.org> User-Agent: Sup/git MIME-Version: 1.0 From: Sascha Silbe Cc: sup-devel Subject: Re: [sup-devel] [PATCH 2/2] {config, sources}.yaml: preserve symlinks and permissions X-BeenThere: sup-devel@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Sup developer discussion List-Id: Sup developer discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0444343575==" Sender: sup-devel-bounces@rubyforge.org Errors-To: sup-devel-bounces@rubyforge.org --===============0444343575== Content-Transfer-Encoding: 8bit Content-Type: multipart/signed; boundary="=-1295455352-744680-7037-6767-5-="; protocol="application/pgp-signature" --=-1295455352-744680-7037-6767-5-= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Excerpts from William Morgan's message of Wed Jan 19 16:38:11 +0100 2011:= > Reformatted excerpts from Sascha Silbe's message of 2011-01-18: > > + unless File.exists?(backup_fn) && File.size(fn) =3D=3D 0 > = > This line is giving me some problems when fn doesn't exist (e.g. when > running sup-sync the first time without a config.yaml). Should it be > = > File.exists?(backup_fn) && File.exists?(fn) && File.size(fn) =3D=3D 0= > = > instead? Yes, you're right. We shouldn't try to do a copy if the original doesn't exist. Sorry for not testing that case. Shall I send a fix-up patch? Sascha -- = http://sascha.silbe.org/ http://www.infra-silbe.de/ --=-1295455352-744680-7037-6767-5-= Content-Disposition: attachment; filename="signature.asc" Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.1.0-git7d24ffa (GNU/Linux) iQEcBAEBCgAGBQJNNxR0AAoJELpz82VMF3DanjcH/02G1dvbJ+Q25mQc8FpxbiUc TT0vx9Kb9C3BOxx8wOePxy4x39M4Xb8dYM85wBWnTMJiR3q+djB63/NMcCKwf0K2 IKl2yQrpIcUSc39KpTlrD2GdpvRFwa9NcBIVv5DfYnbN53AE4K28tKAfVnCxoSDS MUqQtbD9aDGBKQr8fZwz/HWvpxl8o6dNYok2WCc1/zAz7a61OSLxGoK2HFZxHjW9 BKnV8T5KBAEti6lI5c2U02HRVvpjMtqExbs86uapzHZFA+zzG01pIYYlXhFZxmyQ Qdf/GDxzAcQml8Lxq/gu9Ih50mr3Su1lntuC88UqV5B81ug+1Ab3zvUL1kNRXes= =m440 -----END PGP SIGNATURE----- --=-1295455352-744680-7037-6767-5-=-- --===============0444343575== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel --===============0444343575==--