From: Sascha Silbe <sascha-ml-reply-to-2011-1@silbe.org>
To: William Morgan <wmorgan-sup@masanjin.net>
Cc: sup-devel <sup-devel@rubyforge.org>
Subject: Re: [sup-devel] [PATCH 2/2] {config, sources}.yaml: preserve symlinks and permissions
Date: Wed, 19 Jan 2011 17:42:28 +0100 [thread overview]
Message-ID: <1295454858-sup-1718@twin.sascha.silbe.org> (raw)
In-Reply-To: <1295451265-sup-1883@masanjin.net>
[-- Attachment #1.1: Type: text/plain, Size: 667 bytes --]
Excerpts from William Morgan's message of Wed Jan 19 16:38:11 +0100 2011:
> Reformatted excerpts from Sascha Silbe's message of 2011-01-18:
> > + unless File.exists?(backup_fn) && File.size(fn) == 0
>
> This line is giving me some problems when fn doesn't exist (e.g. when
> running sup-sync the first time without a config.yaml). Should it be
>
> File.exists?(backup_fn) && File.exists?(fn) && File.size(fn) == 0
>
> instead?
Yes, you're right. We shouldn't try to do a copy if the original doesn't
exist. Sorry for not testing that case.
Shall I send a fix-up patch?
Sascha
--
http://sascha.silbe.org/
http://www.infra-silbe.de/
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 500 bytes --]
[-- Attachment #2: Type: text/plain, Size: 143 bytes --]
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
next prev parent reply other threads:[~2011-01-19 16:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-18 18:28 [sup-devel] [PATCH 1/2] ensure sources.yaml gets flushed to disk Sascha Silbe
2011-01-18 18:28 ` [sup-devel] [PATCH 2/2] {config, sources}.yaml: preserve symlinks and permissions Sascha Silbe
2011-01-19 3:41 ` Rich Lane
2011-01-19 10:05 ` Sascha Silbe
2011-01-19 15:38 ` William Morgan
2011-01-19 16:42 ` Sascha Silbe [this message]
2011-01-19 17:17 ` William Morgan
2011-01-19 18:44 ` Rich Lane
2011-01-19 17:19 ` William Morgan
2011-01-19 18:41 ` Ben Walton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295454858-sup-1718@twin.sascha.silbe.org \
--to=sascha-ml-reply-to-2011-1@silbe.org \
--cc=sup-devel@rubyforge.org \
--cc=wmorgan-sup@masanjin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox