From: Sascha Silbe <sascha-pgp@silbe.org>
To: sup-devel <sup-devel@rubyforge.org>
Subject: [sup-devel] [PATCH] gen_sign_user_opts: fall back to default account if no account matches sender
Date: Tue, 18 Jan 2011 19:31:21 +0100 [thread overview]
Message-ID: <1295375481-2615-1-git-send-email-sascha-pgp@silbe.org> (raw)
Fixes the following exception:
NoMethodError from thread: main
undefined method `gpgkey' for nil:NilClass
./lib/sup/crypto.rb:226:in `gen_sign_user_opts'
./lib/sup/crypto.rb:48:in `sign'
./lib/sup/util.rb:609:in `send'
./lib/sup/util.rb:609:in `method_missing'
./lib/sup/modes/edit-message-mode.rb:411:in `send'
./lib/sup/modes/edit-message-mode.rb:411:in `build_message'
./lib/sup/modes/edit-message-mode.rb:354:in `send_message'
./lib/sup/mode.rb:59:in `send'
./lib/sup/mode.rb:59:in `handle_input'
./lib/sup/buffer.rb:277:in `handle_input'
bin/sup:260
Signed-off-by: Sascha Silbe <sascha-pgp@silbe.org>
---
The exception originally occured prior to merging the gpgme patch and I
didn't re-test without the patch, but since this part of the code hasn't
changed I expect the results to be the same.
lib/sup/crypto.rb | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/lib/sup/crypto.rb b/lib/sup/crypto.rb
index f8e16c5..02f14d0 100644
--- a/lib/sup/crypto.rb
+++ b/lib/sup/crypto.rb
@@ -323,6 +323,7 @@ private
# else set --local-user from_email_address
def gen_sign_user_opts from
account = AccountManager.account_for from
+ account ||= AccountManager.default_account
if !account.gpgkey.nil?
opts = {:signers => account.gpgkey}
elsif AccountManager.user_emails.length == 1
--
1.7.2.3
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
next reply other threads:[~2011-01-18 18:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-18 18:31 Sascha Silbe [this message]
2011-01-19 3:42 ` Rich Lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295375481-2615-1-git-send-email-sascha-pgp@silbe.org \
--to=sascha-pgp@silbe.org \
--cc=sascha-ml-reply-to-2011-1@silbe.org \
--cc=sup-devel@rubyforge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox