From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.42.229.71 with SMTP id jh7cs147204icb; Tue, 18 Jan 2011 11:28:11 -0800 (PST) Received: by 10.224.61.3 with SMTP id r3mr5579084qah.134.1295378887777; Tue, 18 Jan 2011 11:28:07 -0800 (PST) Return-Path: Received: from rubyforge.org (rubyforge.org [205.234.109.19]) by mx.google.com with ESMTP id nb15si12353008qcb.63.2011.01.18.11.28.07; Tue, 18 Jan 2011 11:28:07 -0800 (PST) Received-SPF: pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19; Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-devel-bounces@rubyforge.org Received: from rubyforge.org (rubyforge.org [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id 1C59E185835E; Tue, 18 Jan 2011 14:28:07 -0500 (EST) Received: from smtp.chost.de (setoy.chost.de [217.160.209.225]) by rubyforge.org (Postfix) with ESMTP id 4A4B0185831A for ; Tue, 18 Jan 2011 13:29:00 -0500 (EST) Received: (qmail 30118 invoked by uid 5015); 18 Jan 2011 18:29:07 -0000 Received: (nullmailer pid 31506 invoked by uid 8193); Tue, 18 Jan 2011 18:28:58 -0000 Received: (nullmailer pid 2571 invoked by uid 8193); Tue, 18 Jan 2011 18:28:55 -0000 From: Sascha Silbe To: sup-devel Date: Tue, 18 Jan 2011 19:28:43 +0100 Message-Id: <1295375324-2496-1-git-send-email-sascha-pgp@silbe.org> X-Mailer: git-send-email 1.7.2.3 Mail-Followup-To: Subject: [sup-devel] [PATCH 1/2] ensure sources.yaml gets flushed to disk X-BeenThere: sup-devel@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Sascha Silbe , Sup developer discussion List-Id: Sup developer discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: sup-devel-bounces@rubyforge.org Errors-To: sup-devel-bounces@rubyforge.org Before renaming sources.yaml we need to fsync() it, otherwise we could end up with an empty file in case of a crash [1]. [1] http://thunk.org/tytso/blog/2009/03/12/delayed-allocation-and-the-zero-length-file-problem/ Signed-off-by: Sascha Silbe --- lib/sup.rb | 10 ++++++++-- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/sup.rb b/lib/sup.rb index edd23c8..09744b4 100644 --- a/lib/sup.rb +++ b/lib/sup.rb @@ -98,10 +98,16 @@ module Redwood if safe safe_fn = "#{File.dirname fn}/safe_#{File.basename fn}" mode = File.stat(fn).mode if File.exists? fn - File.open(safe_fn, "w", mode) { |f| f.puts o.to_yaml } + File.open(safe_fn, "w", mode) do |f| + f.puts o.to_yaml + f.fsync + end FileUtils.mv safe_fn, fn else - File.open(fn, "w") { |f| f.puts o.to_yaml } + File.open(fn, "w") do |f| + f.puts o.to_yaml + f.fsync + end end end -- 1.7.2.3 _______________________________________________ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel