From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.42.229.71 with SMTP id jh7cs146976icb; Tue, 18 Jan 2011 11:18:17 -0800 (PST) Received: by 10.42.179.9 with SMTP id bo9mr6817101icb.429.1295378297687; Tue, 18 Jan 2011 11:18:17 -0800 (PST) Return-Path: Received: from rubyforge.org (rubyforge.org [205.234.109.19]) by mx.google.com with ESMTP id m16si12342897qck.41.2011.01.18.11.18.17; Tue, 18 Jan 2011 11:18:17 -0800 (PST) Received-SPF: pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19; Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-devel-bounces@rubyforge.org Received: from rubyforge.org (rubyforge.org [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id D95051858378; Tue, 18 Jan 2011 14:18:16 -0500 (EST) Received: from smtp.chost.de (setoy.chost.de [217.160.209.225]) by rubyforge.org (Postfix) with ESMTP id 6F2AB185831A for ; Tue, 18 Jan 2011 13:26:44 -0500 (EST) Received: (qmail 30074 invoked by uid 5015); 18 Jan 2011 18:26:52 -0000 Received: (nullmailer pid 31475 invoked by uid 8193); Tue, 18 Jan 2011 18:26:43 -0000 Received: (nullmailer pid 2433 invoked by uid 8193); Tue, 18 Jan 2011 18:26:39 -0000 From: Sascha Silbe To: sup-devel Date: Tue, 18 Jan 2011 19:26:37 +0100 Message-Id: <1295375197-2397-1-git-send-email-sascha-pgp@silbe.org> X-Mailer: git-send-email 1.7.2.3 Mail-Followup-To: Subject: [sup-devel] [PATCH] buffer: throw "friendly" exception if question is too long X-BeenThere: sup-devel@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Sascha Silbe , Sup developer discussion List-Id: Sup developer discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: sup-devel-bounces@rubyforge.org Errors-To: sup-devel-bounces@rubyforge.org If a question is too long to fit on screen, the buffer manager currently throws a hard-to-understand exception deep down in the buffer logic. Explicitly checking for this condition and throwing a descriptive exception makes life easier for hook authors. Signed-off-by: Sascha Silbe --- lib/sup/buffer.rb | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/lib/sup/buffer.rb b/lib/sup/buffer.rb index d1fef5a..25ea132 100644 --- a/lib/sup/buffer.rb +++ b/lib/sup/buffer.rb @@ -575,6 +575,7 @@ EOS ## screen def ask domain, question, default=nil, &block raise "impossible!" if @asking + raise "Question too long" if Ncurses.cols <= question.length @asking = true @textfields[domain] ||= TextField.new -- 1.7.2.3 _______________________________________________ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel