Archive of RubyForge sup-devel mailing list
 help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: sup-devel <sup-devel@rubyforge.org>
Subject: [sup-devel] Use "-- " as a signature separator
Date: Tue, 09 Nov 2010 12:24:13 -0300	[thread overview]
Message-ID: <1289316177-sup-6046@alvh.no-ip.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 258 bytes --]

This patch makes the signature separator always be dash-dash-space; the
current code is inconsistent in that one place is missing the space.
Apparently, it was removed by someone who thought it was unnecessary.

-- 
Álvaro Herrera <alvherre@alvh.no-ip.org>

[-- Attachment #2: 0002-Use-for-signature-separator.patch --]
[-- Type: application/octet-stream, Size: 797 bytes --]

From b7ed62113b5784f4bc27ac60c7921334ccb88af8 Mon Sep 17 00:00:00 2001
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: Tue, 9 Nov 2010 12:10:30 -0300
Subject: [PATCH 2/3] Use "-- " for signature separator

---
 lib/sup/modes/edit-message-mode.rb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/sup/modes/edit-message-mode.rb b/lib/sup/modes/edit-message-mode.rb
index 28082c3..c13c6ae 100644
--- a/lib/sup/modes/edit-message-mode.rb
+++ b/lib/sup/modes/edit-message-mode.rb
@@ -518,7 +518,7 @@ private
              AccountManager.default_account).signature
 
     if sigfn && File.exists?(sigfn)
-      ["", "--"] + File.readlines(sigfn).map { |l| l.chomp }
+      ["", "-- "] + File.readlines(sigfn).map { |l| l.chomp }
     else
       []
     end
-- 
1.7.1


[-- Attachment #3: Type: text/plain, Size: 143 bytes --]

_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel

             reply	other threads:[~2010-11-09 17:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-09 15:24 Alvaro Herrera [this message]
2010-11-15  4:17 ` Rich Lane

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1289316177-sup-6046@alvh.no-ip.org \
    --to=alvherre@alvh.no-ip.org \
    --cc=sup-devel@rubyforge.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox