[sup-devel] [PATCH] Stop double quoting the protocol when sending encrypted emails

* [sup-devel] [PATCH] Stop double quoting the protocol when sending encrypted emails
@ 2010-10-22 15:37 Hamish D
  2010-11-04 16:04 ` Rich Lane
  0 siblings, 1 reply; 2+ messages in thread
From: Hamish D @ 2010-10-22 15:37 UTC (permalink / raw)
  To: sup-devel

[-- Attachment #1: Type: text/plain, Size: 540 bytes --]

Some friends of mine were having trouble with encrypted messages of
mine sent by sup. From the commit message:


Stop double quoting the protocol when sending encrypted emails

It was the case that when encrypting emails, the content-type
header line would look like:
Content-Type: multipart/encrypted;
boundary="=-1287680456-54319-281-6673-1-=";
protocol=""application/pgp-encrypted""
It appears that rmail adds the extra quotes, so this change
makes the protocol unquoted to start with, so we end up with
correct quoting.


Hamish Downer

[-- Attachment #2: 0001-Stop-double-quoting-the-protocol-when-sending-encryp.patch --]
[-- Type: text/x-patch, Size: 1164 bytes --]

From 85a532b6f7e598b5cfde34b221992d5a3f90733f Mon Sep 17 00:00:00 2001
From: Hamish Downer <dmishd@gmail.com>
Date: Fri, 22 Oct 2010 16:18:10 +0100
Subject: [PATCH] Stop double quoting the protocol when sending encrypted emails

It was the case that when encrypting emails, the content-type
header line would look like:
Content-Type: multipart/encrypted; boundary="=-1287680456-54319-281-6673-1-="; protocol=""application/pgp-encrypted""
It appears that rmail adds the extra quotes, so this change
makes the protocol unquoted to start with, so we end up with
correct quoting.
---
 lib/sup/crypto.rb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/sup/crypto.rb b/lib/sup/crypto.rb
index bce01d1..c7b57c1 100644
--- a/lib/sup/crypto.rb
+++ b/lib/sup/crypto.rb
@@ -88,7 +88,7 @@ EOS
     control.body = "Version: 1\n"
 
     envelope = RMail::Message.new
-    envelope.header["Content-Type"] = 'multipart/encrypted; protocol="application/pgp-encrypted"'
+    envelope.header["Content-Type"] = 'multipart/encrypted; protocol=application/pgp-encrypted'
 
     envelope.add_part control
     envelope.add_part encrypted_payload
-- 
1.7.1


[-- Attachment #3: Type: text/plain, Size: 143 bytes --]

_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread