From: Gregor Hoffleit <gregor@hoffleit.de>
To: sup-devel <sup-devel@rubyforge.org>
Subject: [sup-devel] [PATCH] Bugfix: Set background color for starred messages
Date: Tue, 12 Oct 2010 16:34:56 +0200 [thread overview]
Message-ID: <1286893508-sup-7225@sam.mediasupervision.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 465 bytes --]
From the commit message:
For the sake of consistency, Sup should always use the starred_color
for the 'starred' column in the thread-index-mode, whether there's a
star or a blank.
Rationale: With this patch, I'm able to set the background color of
the thread-index to bg:7 without having to change my term's
background color. Without the patch, the background color shines
through in the starred column.
Regards,
Gregor Hoffleit
[-- Attachment #2: 0001-Bugfix-Background-for-starred-messages.patch --]
[-- Type: application/octet-stream, Size: 1178 bytes --]
From 6551fc3e5373cc9f3a32b28b4335a2de2cd2efa4 Mon Sep 17 00:00:00 2001
From: Gregor Hoffleit <gregor@hoffleit.de>
Date: Thu, 27 May 2010 11:40:13 +0200
Subject: [PATCH] Bugfix: Set background color for starred column
For the sake of consistency, Sup should always use the starred_color for the
'starred' column in the thread-index-mode, whether there's a star or a blank.
Rationale: With this patch, I'm able to set the background color of the
thread-index to bg:7 without having to change my term's background color.
Without the patch, the background color shines through in the starred column.
---
lib/sup/modes/thread-index-mode.rb | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/sup/modes/thread-index-mode.rb b/lib/sup/modes/thread-index-mode.rb
index 5f3499c..f012123 100644
--- a/lib/sup/modes/thread-index-mode.rb
+++ b/lib/sup/modes/thread-index-mode.rb
@@ -887,7 +887,7 @@ protected
[
[:tagged_color, @tags.tagged?(t) ? ">" : " "],
[:date_color, date_widget_text],
- (starred ? [:starred_color, "*"] : [:none, " "]),
+ [:starred_color, (starred ? "*" : " ")],
] +
from +
[
--
1.5.6.5
[-- Attachment #3: Type: text/plain, Size: 143 bytes --]
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
next reply other threads:[~2010-10-12 14:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-12 14:34 Gregor Hoffleit [this message]
2010-10-14 1:10 ` Rich Lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286893508-sup-7225@sam.mediasupervision.de \
--to=gregor@hoffleit.de \
--cc=sup-devel@rubyforge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox