From: Michael Stapelberg <michael+sup@stapelberg.de>
To: Rich Lane <rlane@club.cc.cmu.edu>
Cc: sup-devel <sup-devel@rubyforge.org>
Subject: [sup-devel] [PATCH] Bugfix: Don’t display thread participants twice
Date: Thu, 07 Oct 2010 19:21:26 +0200 [thread overview]
Message-ID: <1286471713-sup-9575@midna.zekjur.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 314 bytes --]
Hi,
Quote from the commit message:
When a participant of a thread uses different email addresses, but the same
name, he would be displayed twice in the list:
Participants:
• foo <foo@bar.com>
• foo <foo@qux.bar.com>
• bar <bar@bar.com>
would lead to: "foo, bar, foo"
Best regards,
Michael
[-- Attachment #2: 0001-Bugfix-Don-t-display-thread-participants-twice.patch --]
[-- Type: application/octet-stream, Size: 1198 bytes --]
From 8d18bd3147c7acaa43f76915bdf99bbf10429851 Mon Sep 17 00:00:00 2001
From: Michael Stapelberg <michael@stapelberg.de>
Date: Thu, 7 Oct 2010 17:24:38 +0200
Subject: [PATCH] =?UTF-8?q?Bugfix:=20Don=E2=80=99t=20display=20thread=20participants=20twice?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
When a participant of a thread uses different email addresses, but the same
name, he would be displayed twice in the list:
Participants:
• foo <foo@bar.com>
• foo <foo@qux.bar.com>
• bar <bar@bar.com>
would lead to: "foo, bar, foo"
---
lib/sup/modes/thread-index-mode.rb | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/sup/modes/thread-index-mode.rb b/lib/sup/modes/thread-index-mode.rb
index 0c7a3f2..b3f6c77 100644
--- a/lib/sup/modes/thread-index-mode.rb
+++ b/lib/sup/modes/thread-index-mode.rb
@@ -792,8 +792,8 @@ protected
authors = t.map do |m, *o|
next unless m && m.from
new[m.from] ||= m.has_label?(:unread)
- next if seen[m.from]
- seen[m.from] = true
+ next if seen[m.from.mediumname]
+ seen[m.from.mediumname] = true
m.from
end.compact
--
1.7.1
[-- Attachment #3: Type: text/plain, Size: 143 bytes --]
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
next reply other threads:[~2010-10-07 17:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-07 17:21 Michael Stapelberg [this message]
2010-10-08 4:17 ` Rich Lane
2010-10-08 10:05 ` Gaute Hope
2010-10-08 11:41 ` Michael Stapelberg
2010-10-08 11:46 ` Gaute Hope
2010-10-08 12:07 ` Ben Walton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286471713-sup-9575@midna.zekjur.net \
--to=michael+sup@stapelberg.de \
--cc=rlane@club.cc.cmu.edu \
--cc=sup-devel@rubyforge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox