From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.204.20.129 with SMTP id f1cs17970bkb; Tue, 5 Oct 2010 06:16:28 -0700 (PDT) Received: by 10.231.167.130 with SMTP id q2mr12095924iby.163.1286284587202; Tue, 05 Oct 2010 06:16:27 -0700 (PDT) Return-Path: Received: from rubyforge.org (rubyforge.org [205.234.109.19]) by mx.google.com with ESMTP id x10si1427679iba.54.2010.10.05.06.16.26; Tue, 05 Oct 2010 06:16:27 -0700 (PDT) Received-SPF: pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19; Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-devel-bounces@rubyforge.org Received: from rubyforge.org (rubyforge.org [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id 84A191858373; Tue, 5 Oct 2010 09:16:26 -0400 (EDT) Received: from www.cquest.utoronto.ca (www.cquest.utoronto.ca [192.82.128.5]) by rubyforge.org (Postfix) with ESMTP id EA20C1858373 for ; Tue, 5 Oct 2010 09:09:42 -0400 (EDT) Received: from pinkfloyd.chass.utoronto.ca ([128.100.160.254]:46388 ident=93) by www.cquest.utoronto.ca with esmtp (Exim 4.43) id 1P37H4-0006kQ-7L for sup-devel@rubyforge.org; Tue, 05 Oct 2010 09:09:42 -0400 Received: from bwalton by pinkfloyd.chass.utoronto.ca with local (Exim 4.63) (envelope-from ) id 1P37H4-0003kr-4h for sup-devel@rubyforge.org; Tue, 05 Oct 2010 09:09:42 -0400 From: Ben Walton To: sup-devel In-reply-to: <1286278748-sup-3282@twin.sascha.silbe.org> References: <1283637106-18801-1-git-send-email-michael@content-space.de> <1286278748-sup-3282@twin.sascha.silbe.org> Date: Tue, 05 Oct 2010 09:09:41 -0400 Message-Id: <1286284088-sup-3859@pinkfloyd.chass.utoronto.ca> User-Agent: Sup/git Subject: Re: [sup-devel] [PATCH] Fixed inline gpg crash when the end marker is missing X-BeenThere: sup-devel@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Sup developer discussion List-Id: Sup developer discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: sup-devel-bounces@rubyforge.org Errors-To: sup-devel-bounces@rubyforge.org Excerpts from Sascha Silbe's message of Tue Oct 05 07:42:58 -0400 2010: > Just encountered this one with some message in the "Error when > verifying tags signed using 1.7.3.1" thread [1] on the git mailing > list. The patch works fine for me, thanks! Yes, me too. Patch applied and my sup is back in business. > FWIW, I think your approach of not trying to decrypt mails that > contain no end marker is the right thing to do: If the end marker is > missing, the message most likely has been garbled in other ways as > well (or simply cut off in the middle), causing decryption to fail > anyway. I agree with this rationale. Feeding the entire message to gpg if no end marker is seen isn't the way to go, I don't think. Rich, can this hit master? Thanks -Ben -- Ben Walton Systems Programmer - CHASS University of Toronto C:416.407.5610 | W:416.978.4302 _______________________________________________ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel