From: Ben Walton <bwalton@artsci.utoronto.ca>
To: sup-devel <sup-devel@rubyforge.org>
Subject: Re: [sup-devel] [PATCH] Fixed inline gpg crash when the end marker is missing
Date: Tue, 05 Oct 2010 09:09:41 -0400 [thread overview]
Message-ID: <1286284088-sup-3859@pinkfloyd.chass.utoronto.ca> (raw)
In-Reply-To: <1286278748-sup-3282@twin.sascha.silbe.org>
Excerpts from Sascha Silbe's message of Tue Oct 05 07:42:58 -0400 2010:
> Just encountered this one with some message in the "Error when
> verifying tags signed using 1.7.3.1" thread [1] on the git mailing
> list. The patch works fine for me, thanks!
Yes, me too. Patch applied and my sup is back in business.
> FWIW, I think your approach of not trying to decrypt mails that
> contain no end marker is the right thing to do: If the end marker is
> missing, the message most likely has been garbled in other ways as
> well (or simply cut off in the middle), causing decryption to fail
> anyway.
I agree with this rationale. Feeding the entire message to gpg if no
end marker is seen isn't the way to go, I don't think.
Rich, can this hit master?
Thanks
-Ben
--
Ben Walton
Systems Programmer - CHASS
University of Toronto
C:416.407.5610 | W:416.978.4302
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
next prev parent reply other threads:[~2010-10-05 13:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AANLkTimw-xi2XCdn3R3QHoDFFv-4cD7GxCoHWxbta-0r@mail.gmail.com>
2010-09-04 21:51 ` Michael Hamann
2010-09-11 16:42 ` Edward Z. Yang
2010-10-05 11:42 ` Sascha Silbe
2010-10-05 13:09 ` Ben Walton [this message]
2010-10-08 4:23 ` Rich Lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286284088-sup-3859@pinkfloyd.chass.utoronto.ca \
--to=bwalton@artsci.utoronto.ca \
--cc=sup-devel@rubyforge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox