From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.204.20.129 with SMTP id f1cs73409bkb; Wed, 29 Sep 2010 05:23:13 -0700 (PDT) Received: by 10.100.45.14 with SMTP id s14mr1703128ans.249.1285762991863; Wed, 29 Sep 2010 05:23:11 -0700 (PDT) Return-Path: Received: from rubyforge.org (rubyforge.org [205.234.109.19]) by mx.google.com with ESMTP id x13si15026760anc.63.2010.09.29.05.23.11; Wed, 29 Sep 2010 05:23:11 -0700 (PDT) Received-SPF: pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19; Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-devel-bounces@rubyforge.org Received: from rubyforge.org (rubyforge.org [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id A9DC4177994E; Wed, 29 Sep 2010 08:23:10 -0400 (EDT) Received: from entry.masanjin.net (masanjin.net [209.20.72.13]) by rubyforge.org (Postfix) with ESMTP id 042F8177994E for ; Wed, 29 Sep 2010 08:22:51 -0400 (EDT) Received: from localhost ([127.0.0.1] helo=entry.masanjin.net) by entry.masanjin.net with esmtp (Exim 4.69) (envelope-from ) id 1P0vgO-0001gc-T3 for sup-devel@rubyforge.org; Wed, 29 Sep 2010 08:22:50 -0400 MIME-Version: 1.0 To: sup-devel@rubyforge.org From: Sascha Silbe Date: Wed, 29 Sep 2010 12:22:48 +0000 Precedence: bulk X-Roundup-Name: Sup issue tracker X-Roundup-Loop: hello X-Roundup-Version: 1.4.10 Message-Id: <1285762968.52.0.37349243868.issue122@masanjin.net> X-Roundup-issue-status: unread X-Roundup-issue-priority: bug In-Reply-To: <1285762968.52.0.37349243868.issue122@masanjin.net> Subject: [sup-devel] [issue122] editing labels in thread view mode messes up labels of all messages in thread, even after undo X-BeenThere: sup-devel@rubyforge.org X-Mailman-Version: 2.1.12 Reply-To: Sup issue tracker , Sup developer discussion List-Id: Sup developer discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: sup-devel-bounces@rubyforge.org Errors-To: sup-devel-bounces@rubyforge.org New submission from Sascha Silbe : When changing labels in thread view mode (and probably also in thread index / inbox mode), labels for _all_ messages of the thread are set to be exactly the same. Apart from not being what the user expects, it also messes up special labels like :attachment. Even worse, the undo block also sets the labels of all messages to the union of the previous labels, thereby not(completely) undoing the effect. At the very least, undo should work properly and only labels that have actually been added or removed by the user should be touched. This would preserve the state of both the special labels and any source-specific labels that were not explicitly changed by the user. I would also expect edit_labels to only apply to the current message in thread view mode. If you disagree, please consider adding an edit_message_labels keybinding. This would especially be useful for managing "todo lists". ---------- messages: 288 nosy: sascha_silbe priority: bug ruby_version: 1.8.x status: unread sup_version: git master (45c3433) title: editing labels in thread view mode messes up labels of all messages in thread, even after undo _________________________________________ Sup issue tracker _________________________________________ _______________________________________________ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel