From: Sascha Silbe <sup-bugs@masanjin.net>
To: sup-devel@rubyforge.org
Subject: [sup-devel] [issue122] editing labels in thread view mode messes up labels of all messages in thread, even after undo
Date: Wed, 29 Sep 2010 12:22:48 +0000 [thread overview]
Message-ID: <1285762968.52.0.37349243868.issue122@masanjin.net> (raw)
In-Reply-To: <1285762968.52.0.37349243868.issue122@masanjin.net>
New submission from Sascha Silbe <sascha-web-masanjin.net-sup-bugs@silbe.org>:
When changing labels in thread view mode (and probably also in thread index / inbox mode), labels for _all_ messages of the thread are set to be exactly the same. Apart from not being what the user expects, it also messes up special labels like :attachment.
Even worse, the undo block also sets the labels of all messages to the union of the previous labels, thereby not(completely) undoing the effect.
At the very least, undo should work properly and only labels that have actually been added or removed by the user should be touched. This would preserve the state of both the special labels and any source-specific labels that were not explicitly changed by the user.
I would also expect edit_labels to only apply to the current message in thread view mode. If you disagree, please consider adding an edit_message_labels keybinding. This would especially be useful for managing "todo lists".
----------
messages: 288
nosy: sascha_silbe
priority: bug
ruby_version: 1.8.x
status: unread
sup_version: git master (45c3433)
title: editing labels in thread view mode messes up labels of all messages in thread, even after undo
_________________________________________
Sup issue tracker <sup-bugs@masanjin.net>
<http://masanjin.net/sup-bugs/issue122>
_________________________________________
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
parent reply other threads:[~2010-09-29 12:23 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1285762968.52.0.37349243868.issue122@masanjin.net>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285762968.52.0.37349243868.issue122@masanjin.net \
--to=sup-bugs@masanjin.net \
--cc=sup-devel@rubyforge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox