From: Marc Hartstein <marc.hartstein@alum.vassar.edu>
To: sup-devel <sup-devel@rubyforge.org>
Subject: Re: [sup-devel] [issue117] Problem with "special" characters (space etc.) in source uri (filesystem path).
Date: Thu, 19 Aug 2010 13:44:49 -0400 [thread overview]
Message-ID: <1282239630-sup-7131@cabinet> (raw)
In-Reply-To: <1282204722.55.0.502666868043.issue117@masanjin.net>
[-- Attachment #1.1: Type: text/plain, Size: 828 bytes --]
Excerpts from anonymous's message of Thu Aug 19 03:58:42 -0400 2010:
>
> uri=URI.encode(uri) ### <--- Added this line in order to encode "special"
> characters within the uri.
>
> This makes sup-add work, it encodes the non-standard characters (like
> "%20" for " "). They appear as such in sources.yaml. But this breaks
> another part: sup-sync now looks for files containing "%20" instead of
> " " on the disk, which obviously don't exist:
If you're going to URI encode the source URIs (makes sense if they're
truly URIs), you're going to have to URI decode them before use.
I'm not sure if this is the best approach, but you should be able to
turn what you've done into a working patch by finding the places where
sup uses the URIs and using URI.decode(uri) to turn them back into
normal strings at the right moment.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 143 bytes --]
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
prev parent reply other threads:[~2010-08-19 18:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-19 7:58 anonymous
2010-08-19 17:44 ` Marc Hartstein [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282239630-sup-7131@cabinet \
--to=marc.hartstein@alum.vassar.edu \
--cc=sup-devel@rubyforge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox