From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: anonymous <sup-bugs@masanjin.net>
Cc: sup-devel <sup-devel@rubyforge.org>
Subject: Re: [sup-devel] [issue114] Better quoted-text / top-post stripping
Date: Wed, 04 Aug 2010 10:22:26 -0400 [thread overview]
Message-ID: <1280931423-sup-2397@alvh.no-ip.org> (raw)
In-Reply-To: <1280925073.15.0.143313290118.issue114@masanjin.net>
Excerpts from anonymous's message of mié ago 04 08:31:13 -0400 2010:
> Redwood::Message splits a message into chunks and hides quoted text from a
> previous message.
>
> Top-posted responses are supported with BLOCK_QUOTE_PATTERN. This patch i) adds
> a new pattern to hide top-posted text from Microsoft Entourage, ii) adds a fix
> for Mozilla-based mail users who top post and iii) adds a new array-based config
> option "block_quote_patterns" for adding additional patterns to treat as marking
> the top of a top-posted response.
+1 for improving the top-posted detection in general.
I think this regex
+ # Microsoft Entourage doesn't indent quoted text, but it can be spotted
+ # with this line:
+ # On 8/2/10 1:23 PM, "John Doe" <edward@facebook.com> wrote:
+ /^On \d+\/\d+\/\d+ .+ wrote:/,
is way too general; it could easily match the attribution line on a
non-top-posted quoted email. I didn't try it but I think it would end
up trimming the whole contents of several emails I have on my inboxes
(which is pretty annoying --- I have set SIG_PATTERN to be just "^-- "
to avoid this very problem).
There's a small bug here:
+ # At least three dashes. Mozilla mail clients downcase the 'm' in
+ # message.
+ /^----+\s*Original (M|m)essage\s*----+/,
Note that it matches only four or more dashes, not three as the comment says.
--
Álvaro Herrera <alvherre@alvh.no-ip.org>
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
prev parent reply other threads:[~2010-08-04 14:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-04 12:31 anonymous
2010-08-04 14:22 ` Alvaro Herrera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280931423-sup-2397@alvh.no-ip.org \
--to=alvherre@alvh.no-ip.org \
--cc=sup-bugs@masanjin.net \
--cc=sup-devel@rubyforge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox