* [sup-devel] [PATCH] Use the configured real name combined with the actual email address as Sender when replying
@ 2010-07-27 12:54 Michael Stapelberg
2010-07-27 16:16 ` Robin Burchell
0 siblings, 1 reply; 3+ messages in thread
From: Michael Stapelberg @ 2010-07-27 12:54 UTC (permalink / raw)
To: sup-devel
[-- Attachment #1: Type: text/plain, Size: 242 bytes --]
Hi,
quote from the commit message:
For example, mails with "To: michael+sup@stapelberg.de" don't get the
sender "michael+sup <michael+sup@stapelberg.de>" anymore but
"Michael Stapelberg <michael+sup@stapelberg.de>"
Best regards,
Michael
[-- Attachment #2: 0001-Use-the-configured-real-name-combined-with-the-actua.patch --]
[-- Type: application/octet-stream, Size: 1313 bytes --]
From f8be268c221f666d4db4eb09c0f547d76df511bb Mon Sep 17 00:00:00 2001
From: Michael Stapelberg <michael@stapelberg.de>
Date: Tue, 27 Jul 2010 14:37:01 +0200
Subject: [PATCH] Use the configured real name combined with the actual email address as Sender when replying
For example, mails with "To: michael+sup@stapelberg.de" don't get the
sender "michael+sup <michael+sup@stapelberg.de>" anymore but
"Michael Stapelberg <michael+sup@stapelberg.de>"
---
lib/sup/modes/reply-mode.rb | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/lib/sup/modes/reply-mode.rb b/lib/sup/modes/reply-mode.rb
index bbac922..74ffe5d 100644
--- a/lib/sup/modes/reply-mode.rb
+++ b/lib/sup/modes/reply-mode.rb
@@ -76,7 +76,11 @@ EOS
## otherwise, try and find an account somewhere in the list of to's
## and cc's.
elsif(b = (@m.to + @m.cc).find { |p| AccountManager.is_account? p })
- b
+ ## Because people do not always include the full name in the recipient
+ ## field of their mails, we compose the configured realname of this
+ ## account with the email address the mail was sent to
+ acc = AccountManager.account_for b.email
+ Person.new acc.name, b.email
## if all else fails, use the default
else
AccountManager.default_account
--
1.7.1
[-- Attachment #3: Type: text/plain, Size: 143 bytes --]
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [sup-devel] [PATCH] Use the configured real name combined with the actual email address as Sender when replying
2010-07-27 12:54 [sup-devel] [PATCH] Use the configured real name combined with the actual email address as Sender when replying Michael Stapelberg
@ 2010-07-27 16:16 ` Robin Burchell
2010-07-27 16:38 ` Michael Stapelberg
0 siblings, 1 reply; 3+ messages in thread
From: Robin Burchell @ 2010-07-27 16:16 UTC (permalink / raw)
To: sup-devel
Hi Michael,
Excerpts from Michael Stapelberg's message of Tue Jul 27 13:54:57 +0100 2010:
> Hi,
>
> quote from the commit message:
> For example, mails with "To: michael+sup@stapelberg.de" don't get the
> sender "michael+sup <michael+sup@stapelberg.de>" anymore but
> "Michael Stapelberg <michael+sup@stapelberg.de>"
I made a similar (though not perfect) fix which, I guess from your mail, never
got through the moderation queue to sup-devel.
See:
http://github.com/rburchell/sup/commit/efd9752fc62d14fbabecf7719c42f13643c21db
> Best regards,
> Michael
--
Robin Burchell
http://rburchell.com
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [sup-devel] [PATCH] Use the configured real name combined with the actual email address as Sender when replying
2010-07-27 16:16 ` Robin Burchell
@ 2010-07-27 16:38 ` Michael Stapelberg
0 siblings, 0 replies; 3+ messages in thread
From: Michael Stapelberg @ 2010-07-27 16:38 UTC (permalink / raw)
To: sup-devel
Hi Robin,
Excerpts from Robin Burchell's message of 2010-07-27 18:16:48 +0200:
> I made a similar (though not perfect) fix which, I guess from your mail, never
> got through the moderation queue to sup-devel.
Not sure, at least it did not get merged into mainline as of today. Also, your
patch does not consider the regexes/alternates system but always just uses the
main email address.
Best regards,
Michael
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-07-27 16:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-07-27 12:54 [sup-devel] [PATCH] Use the configured real name combined with the actual email address as Sender when replying Michael Stapelberg
2010-07-27 16:16 ` Robin Burchell
2010-07-27 16:38 ` Michael Stapelberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox