Re: [sup-devel] Adding backward synchronization for Maildir sources

From: "Edward Z. Yang" <ezyang@MIT.EDU>
To: Damien Leone <damien.leone@fensalir.fr>
Cc: sup-devel <sup-devel@rubyforge.org>
Subject: Re: [sup-devel] Adding backward synchronization for Maildir sources
Date: Tue, 20 Jul 2010 20:44:38 -0400	[thread overview]
Message-ID: <1279672865-sup-6946@ezyang> (raw)
In-Reply-To: <1279618205-sup-993@mailer>

Excerpts from Damien Leone's message of Tue Jul 20 05:39:41 -0400 2010:
> Excerpts from Edward Z. Yang's message of Mon Jul 19 00:46:33 +0200 2010:
> > It makes Sup very crashy and there's some strange behavior.  This is probably
> > the sixth time I'm composing this message (yeah, haven't learned my
> > lesson.) In more detail...
> 
> I'm impressed, I never experienced such crashes, it is quite stable
> here but I use only very basic hooks.

In retrospect, I'm fairly certain the majority of crashes were from user hooks.

> > * Backwards syncing appears to make old deleted mail show up again; I'm not
> >   sure if it's because touching the Maildir causes Sup to pick up on deleted
> >   tags again or something, but I had to go back and delete lots of deleted mail.
> 
> Hmm, strange, do you use the latest commits of the branch? I pushed a
> fix for deleted mails about 10 days ago.
> 
> The mails that show up again don't have the deleted flag at all?

My Sup is running off of f150276f62e263d146fa81ede645b5e90e06a8a1.  They don't
appear to have the deleted flag, but I didn't look too closely.  It's *possible*
that a regular synchronization would have picked them up, if they accidentally
got dropped from my Sup index but were still inside my Maildir.  I suggest not
worrying too much about this unless someone else reproduces.

> I did not test the code with hooks, what do you suggest for this one?

I mentioned this in the id and Nil message; basically, when iterating over all
messages messages might disappear, and some hooks need to check if a message is
Nil before doing anything to it.

> > * In a similar vein, while messages are going away, '@' will occasionally return
> >   no messages (pressing again usually fixes it).  Messages that are labelled inbox
> >   will show up in 'U', but not in the inbox view without a Sup restart.
> 
> I never use this keybinding but indeed I noticed that pressing '@' two
> times in a row was not showing anything.

It is possible that this is a bug in vanilla Sup.

Cheers,
Edward
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel