From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.204.155.88 with SMTP id r24cs68572bkw; Mon, 19 Jul 2010 14:41:46 -0700 (PDT) Received: by 10.231.172.70 with SMTP id k6mr5531956ibz.125.1279575705366; Mon, 19 Jul 2010 14:41:45 -0700 (PDT) Return-Path: Received: from rubyforge.org (rubyforge.org [205.234.109.19]) by mx.google.com with ESMTP id c18si11620231ibi.25.2010.07.19.14.41.44; Mon, 19 Jul 2010 14:41:45 -0700 (PDT) Received-SPF: pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19; Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-devel-bounces@rubyforge.org Received: from rubyforge.org (rubyforge.org [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id 758FC19782DB; Mon, 19 Jul 2010 17:41:44 -0400 (EDT) Received: from twice-irc.de (mx2.twice-irc.de [79.140.35.195]) by rubyforge.org (Postfix) with ESMTP id C257A185835E for ; Mon, 19 Jul 2010 17:38:19 -0400 (EDT) Received: from midna.zekjur.net (midna.zekjur.net [IPv6:2001:4d88:1008:4242:21c:c0ff:fe7e:4776]) by twice-irc.de (Postfix) with ESMTPSA id 73712166635 for ; Mon, 19 Jul 2010 23:38:19 +0200 (CEST) Received: by midna.zekjur.net (Postfix, from userid 101) id 95D552A4A0; Mon, 19 Jul 2010 23:38:18 +0200 (CEST) From: Michael Stapelberg To: sup-devel Date: Mon, 19 Jul 2010 23:38:18 +0200 Message-Id: <1279575318-sup-7427@midna.zekjur.net> User-Agent: Sup/git Content-Transfer-Encoding: 8bit Content-Type: multipart/mixed; boundary="=-1279575498-593150-16179-3715-3-=" MIME-Version: 1.0 Subject: [sup-devel] (REVIEW NEEDED) [PATCH] Recode attachments to UTF-8 when forwarding X-BeenThere: sup-devel@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Sup developer discussion List-Id: Sup developer discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: sup-devel-bounces@rubyforge.org Errors-To: sup-devel-bounces@rubyforge.org --=-1279575498-593150-16179-3715-3-= Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Hi, can you please review the attached patch? It recodes attachments from whichever charset they are encoded in to UTF-8 when forwarding messages in order to please rmail (it crashes with attachments encoded in Windows-1252 otherwise). FYI, the crash backtrace is the following (pathes shortened): --- Encoding::CompatibilityError from thread: main incompatible character encodings: UTF-8 and ASCII-8BIT rmail-1.0.0/lib/rmail/serialize.rb:112:in `serialize_low' rmail-1.0.0/lib/rmail/serialize.rb:99:in `block in serialize_low' rmail-1.0.0/lib/rmail/message.rb:155:in `block in each_part' rmail-1.0.0/lib/rmail/message.rb:154:in `each' rmail-1.0.0/lib/rmail/message.rb:154:in `each_part' rmail-1.0.0/lib/rmail/serialize.rb:96:in `serialize_low' rmail-1.0.0/lib/rmail/serialize.rb:63:in `serialize' rmail-1.0.0/lib/rmail/message.rb:146:in `to_s' sup/lib/sup/modes/edit-message-mode.rb:344:in `puts' sup/lib/sup/modes/edit-message-mode.rb:344:in `block in send_message' sup/lib/sup/modes/edit-message-mode.rb:344:in `popen' sup/lib/sup/modes/edit-message-mode.rb:344:in `send_message' sup/lib/sup/mode.rb:59:in `handle_input' sup/lib/sup/buffer.rb:277:in `handle_input' So, if you have a better way of handling this, please let us know. Best regards, Michael --=-1279575498-593150-16179-3715-3-= Content-Disposition: attachment; filename="0001-Recode-attachments-to-UTF-8-when-forwarding.patch" Content-Type: application/octet-stream; name="0001-Recode-attachments-to-UTF-8-when-forwarding.patch" Content-Transfer-Encoding: base64 RnJvbSBhYzYzMmNjOWJmZTU4MTUzMDNmOWRmYTY3MWU0MWY0Zjg4Njc4ZjA3 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNaWNoYWVsIFN0YXBl bGJlcmcgPG1pY2hhZWxAc3RhcGVsYmVyZy5kZT4KRGF0ZTogTW9uLCAxOSBK dWwgMjAxMCAyMzozMzowMCArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIFJlY29k ZSBhdHRhY2htZW50cyB0byBVVEYtOCB3aGVuIGZvcndhcmRpbmcKTUlNRS1W ZXJzaW9uOiAxLjAKQ29udGVudC1UeXBlOiB0ZXh0L3BsYWluOyBjaGFyc2V0 PVVURi04CkNvbnRlbnQtVHJhbnNmZXItRW5jb2Rpbmc6IDhiaXQKClRoaXMg aXMgbmVjZXNzYXJ5IGJlY2F1c2Ugcm1haWwgY3Jhc2hlcyBpZiB3ZSBkb27i gJl0IChhbmQgdGhlIGF0dGFjaG1lbnQKaXMgZW5jb2RlZCBpbiBXaW5kb3dz LTEyNTIsIGZvciBleGFtcGxlKS4KLS0tCiBsaWIvc3VwL21lc3NhZ2UtY2h1 bmtzLnJiICAgICB8ICAgIDQgKysrLQogbGliL3N1cC9tZXNzYWdlLnJiICAg ICAgICAgICAgfCAgICAyICstCiBsaWIvc3VwL21vZGVzL2ZvcndhcmQtbW9k ZS5yYiB8ICAgIDIgKy0KIGxpYi9zdXAvdXRpbC5yYiAgICAgICAgICAgICAg IHwgICAgOSArKysrKysrKy0KIDQgZmlsZXMgY2hhbmdlZCwgMTMgaW5zZXJ0 aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saWIvc3Vw L21lc3NhZ2UtY2h1bmtzLnJiIGIvbGliL3N1cC9tZXNzYWdlLWNodW5rcy5y YgppbmRleCBjMjc1ZjQxLi5jYzYxM2FmIDEwMDY0NAotLS0gYS9saWIvc3Vw L21lc3NhZ2UtY2h1bmtzLnJiCisrKyBiL2xpYi9zdXAvbWVzc2FnZS1jaHVu a3MucmIKQEAgLTgzLDggKzgzLDkgQEAgRU9TCiAgICAgYXR0cl9yZWFkZXIg OmNvbnRlbnRfdHlwZSwgOmZpbGVuYW1lLCA6bGluZXMsIDpyYXdfY29udGVu dAogICAgIGJvb2xfcmVhZGVyIDpxdW90YWJsZQogCi0gICAgZGVmIGluaXRp YWxpemUgY29udGVudF90eXBlLCBmaWxlbmFtZSwgZW5jb2RlZF9jb250ZW50 LCBzaWJsaW5nX3R5cGVzCisgICAgZGVmIGluaXRpYWxpemUgY29udGVudF90 eXBlLCBjaGFyc2V0LCBmaWxlbmFtZSwgZW5jb2RlZF9jb250ZW50LCBzaWJs aW5nX3R5cGVzCiAgICAgICBAY29udGVudF90eXBlID0gY29udGVudF90eXBl LmRvd25jYXNlCisgICAgICBAY2hhcnNldCA9IGNoYXJzZXQKICAgICAgIEBm aWxlbmFtZSA9IGZpbGVuYW1lCiAgICAgICBAcXVvdGFibGUgPSBmYWxzZSAj IGNoYW5nZWQgdG8gdHJ1ZSBpZiB3ZSBjYW4gcGFyc2UgaXQgdGhyb3VnaCB0 aGUKICAgICAgICAgICAgICAgICAgICAgICAgICMgbWltZS1kZWNvZGUgaG9v aywgb3IgaWYgaXQncyBwbGFpbiB0ZXh0CkBAIC0xMTMsNiArMTE0LDcgQEAg RU9TCiAgICAgICBlbmQKICAgICBlbmQKIAorICAgIGRlZiBjaGFyc2V0OyBA Y2hhcnNldCBlbmQKICAgICBkZWYgY29sb3I7IDpub25lIGVuZAogICAgIGRl ZiBwYXRpbmFfY29sb3I7IDphdHRhY2htZW50X2NvbG9yIGVuZAogICAgIGRl ZiBwYXRpbmFfdGV4dApkaWZmIC0tZ2l0IGEvbGliL3N1cC9tZXNzYWdlLnJi IGIvbGliL3N1cC9tZXNzYWdlLnJiCmluZGV4IDlmNDg4YWYuLjU3ZjFkZjEg MTAwNjQ0Ci0tLSBhL2xpYi9zdXAvbWVzc2FnZS5yYgorKysgYi9saWIvc3Vw L21lc3NhZ2UucmIKQEAgLTUwNSw3ICs1MDUsNyBAQCBwcml2YXRlCiAgICAg ICAgIEBhdHRhY2htZW50cy5wdXNoIGZpbGVuYW1lLmRvd25jYXNlIHVubGVz cyBmaWxlbmFtZSA9fiAvXnN1cC1hdHRhY2htZW50LS8KICAgICAgICAgYWRk X2xhYmVsIDphdHRhY2htZW50IHVubGVzcyBmaWxlbmFtZSA9fiAvXnN1cC1h dHRhY2htZW50LS8KICAgICAgICAgY29udGVudF90eXBlID0gKG0uaGVhZGVy LmNvbnRlbnRfdHlwZSB8fCAiYXBwbGljYXRpb24vdW5rbm93biIpLmRvd25j YXNlICMgc29tZXRpbWVzIFJ1YnlNYWlsIGdpdmVzIHVzIG5pbAotICAgICAg ICBbQ2h1bms6OkF0dGFjaG1lbnQubmV3KGNvbnRlbnRfdHlwZSwgZmlsZW5h bWUsIG0sIHNpYmxpbmdfdHlwZXMpXQorICAgICAgICBbQ2h1bms6OkF0dGFj aG1lbnQubmV3KGNvbnRlbnRfdHlwZSwgbS5jaGFyc2V0LCBmaWxlbmFtZSwg bSwgc2libGluZ190eXBlcyldCiAKICAgICAgICMjIG90aGVyd2lzZSwgaXQn cyBib2R5IHRleHQKICAgICAgIGVsc2UKZGlmZiAtLWdpdCBhL2xpYi9zdXAv bW9kZXMvZm9yd2FyZC1tb2RlLnJiIGIvbGliL3N1cC9tb2Rlcy9mb3J3YXJk LW1vZGUucmIKaW5kZXggOTQyOGI0Yi4uMDc3OWI0YSAxMDA2NDQKLS0tIGEv bGliL3N1cC9tb2Rlcy9mb3J3YXJkLW1vZGUucmIKKysrIGIvbGliL3N1cC9t b2Rlcy9mb3J3YXJkLW1vZGUucmIKQEAgLTQzLDcgKzQzLDcgQEAgY2xhc3Mg Rm9yd2FyZE1vZGUgPCBFZGl0TWVzc2FnZU1vZGUKIAogICAgIGF0dGFjaG1l bnRzLmVhY2ggZG8gfGN8CiAgICAgICBtaW1lX3R5cGUgPSBNSU1FOjpUeXBl c1tjLmNvbnRlbnRfdHlwZV0uZmlyc3QgfHwgTUlNRTo6VHlwZXNbImFwcGxp Y2F0aW9uL29jdGV0LXN0cmVhbSJdLmZpcnN0Ci0gICAgICBhdHRhY2htZW50 X2hhc2hbYy5maWxlbmFtZV0gPSBSTWFpbDo6TWVzc2FnZS5tYWtlX2F0dGFj aG1lbnQgYy5yYXdfY29udGVudCwgbWltZV90eXBlLmNvbnRlbnRfdHlwZSwg bWltZV90eXBlLmVuY29kaW5nLCBjLmZpbGVuYW1lCisgICAgICBhdHRhY2ht ZW50X2hhc2hbYy5maWxlbmFtZV0gPSBSTWFpbDo6TWVzc2FnZS5tYWtlX2F0 dGFjaG1lbnQgYy5yYXdfY29udGVudCwgbWltZV90eXBlLmNvbnRlbnRfdHlw ZSwgbWltZV90eXBlLmVuY29kaW5nLCBjLmZpbGVuYW1lLCBjLmNoYXJzZXQK ICAgICBlbmQKIAogICAgIG1vZGUgPSBGb3J3YXJkTW9kZS5uZXcgOm1lc3Nh Z2UgPT4gb3B0c1s6bWVzc2FnZV0sIDp0byA9PiB0bywgOmNjID0+IGNjLCA6 YmNjID0+IGJjYywgOmF0dGFjaG1lbnRzID0+IGF0dGFjaG1lbnRfaGFzaApk aWZmIC0tZ2l0IGEvbGliL3N1cC91dGlsLnJiIGIvbGliL3N1cC91dGlsLnJi CmluZGV4IGQxOWNhY2EuLjMxY2Y4MjQgMTAwNjQ0Ci0tLSBhL2xpYi9zdXAv dXRpbC5yYgorKysgYi9saWIvc3VwL3V0aWwucmIKQEAgLTc5LDExICs3OSwx OCBAQCBtb2R1bGUgUk1haWwKICAgICAgIGVuZAogICAgIGVuZAogCi0gICAg ZGVmIHNlbGYubWFrZV9hdHRhY2htZW50IHBheWxvYWQsIG1pbWVfdHlwZSwg ZW5jb2RpbmcsIGZpbGVuYW1lCisgICAgZGVmIHNlbGYubWFrZV9hdHRhY2ht ZW50IHBheWxvYWQsIG1pbWVfdHlwZSwgZW5jb2RpbmcsIGZpbGVuYW1lLCBj aGFyc2V0CiAgICAgICBhID0gTWVzc2FnZS5uZXcKICAgICAgIGEuaGVhZGVy LmFkZCAiQ29udGVudC1EaXNwb3NpdGlvbiIsICJhdHRhY2htZW50OyBmaWxl bmFtZT0je2ZpbGVuYW1lLmluc3BlY3R9IgogICAgICAgYS5oZWFkZXIuYWRk ICJDb250ZW50LVR5cGUiLCAiI3ttaW1lX3R5cGV9OyBuYW1lPSN7ZmlsZW5h bWUuaW5zcGVjdH0iCiAgICAgICBhLmhlYWRlci5hZGQgIkNvbnRlbnQtVHJh bnNmZXItRW5jb2RpbmciLCBlbmNvZGluZyBpZiBlbmNvZGluZworICAgICAg IyMgaWYgd2UgaGF2ZSBjaGFyc2V0IGluZm9ybWF0aW9uLCB3ZSByZWNvZGUg dGhlIGF0dGFjaG1lbnQgdG8gVVRGLTggYmVjYXVzZQorICAgICAgIyMgcm1h aWwgd2lsbCBub3QgYWNjZXB0IGl0IG90aGVyd2lzZS4gVGhpcyBpcyBhIGJp dCBrbHVkZ3kgc2luY2UgYSBtYWlsZXIKKyAgICAgICMjIHNob3VsZCBub3Qg dG91Y2ggZm9yd2FyZGVkIGNvbnRlbnQsIElNTyAoYnV0IGl0J3MgYmV0dGVy IHRoYW4gY3Jhc2hpbmcpLgorICAgICAgaWYgY2hhcnNldAorICAgICAgICBh LmhlYWRlci5hZGQgIkNvbnRlbnQtQ2hhcnNldCIsICJVVEYtOCIKKyAgICAg ICAgcGF5bG9hZCA9IHBheWxvYWQuZm9yY2VfZW5jb2RpbmcoY2hhcnNldCku ZW5jb2RlKCJVVEYtOCIpCisgICAgICBlbmQKICAgICAgIGEuYm9keSA9CiAg ICAgICAgIGNhc2UgZW5jb2RpbmcKICAgICAgICAgd2hlbiAiYmFzZTY0Igot LSAKMS42LjUKCg== --=-1279575498-593150-16179-3715-3-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel --=-1279575498-593150-16179-3715-3-=--