From mboxrd@z Thu Jan  1 00:00:00 1970
Received: by 10.204.35.68 with SMTP id o4cs68604bkd;
        Mon, 12 Jul 2010 19:33:13 -0700 (PDT)
Received: by 10.229.242.3 with SMTP id lg3mr8749665qcb.233.1278988392348;
        Mon, 12 Jul 2010 19:33:12 -0700 (PDT)
Return-Path: <sup-devel-bounces@rubyforge.org>
Received: from rubyforge.org (rubyforge.org [205.234.109.19])
        by mx.google.com with ESMTP id l1si6488197qck.106.2010.07.12.19.33.11;
        Mon, 12 Jul 2010 19:33:12 -0700 (PDT)
Received-SPF: pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19;
Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-devel-bounces@rubyforge.org
Received: from rubyforge.org (rubyforge.org [127.0.0.1])
	by rubyforge.org (Postfix) with ESMTP id 8C405185837B;
	Mon, 12 Jul 2010 22:32:57 -0400 (EDT)
Received: from pion.club.cc.cmu.edu (PION.CLUB.CC.CMU.EDU [128.237.157.88])
	by rubyforge.org (Postfix) with ESMTP id 9429519782CD
	for <sup-devel@rubyforge.org>; Mon, 12 Jul 2010 22:23:48 -0400 (EDT)
Received: from rlane by pion.club.cc.cmu.edu with local (Exim 4.69)
	(envelope-from <rlane@zyrg.net>)
	id 1OYV9u-0001P6-Ur; Mon, 12 Jul 2010 22:23:47 -0400
From: Rich Lane <rlane@club.cc.cmu.edu>
To: Sascha Silbe <sascha-pgp@silbe.org>
In-reply-to: <1278609322-1401-1-git-send-email-sascha-pgp@silbe.org>
References: <1278609322-1401-1-git-send-email-sascha-pgp@silbe.org>
Date: Mon, 12 Jul 2010 22:23:46 -0400
Message-Id: <1278987576-sup-9788@zyrg.net>
User-Agent: Sup/git
Cc: sup-devel <sup-devel@rubyforge.org>
Subject: Re: [sup-devel] [PATCH] don't leak fds for mbox sources
X-BeenThere: sup-devel@rubyforge.org
X-Mailman-Version: 2.1.12
Precedence: list
Reply-To: Sup developer discussion <sup-devel@rubyforge.org>
List-Id: Sup developer discussion <sup-devel.rubyforge.org>
List-Unsubscribe: <http://rubyforge.org/mailman/options/sup-devel>,
	<mailto:sup-devel-request@rubyforge.org?subject=unsubscribe>
List-Archive: <http://rubyforge.org/pipermail/sup-devel>
List-Post: <mailto:sup-devel@rubyforge.org>
List-Help: <mailto:sup-devel-request@rubyforge.org?subject=help>
List-Subscribe: <http://rubyforge.org/mailman/listinfo/sup-devel>,
	<mailto:sup-devel-request@rubyforge.org?subject=subscribe>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: sup-devel-bounces@rubyforge.org
Errors-To: sup-devel-bounces@rubyforge.org

This patch also won't apply once the source rewrite is merged. It's
definitely a good idea though, so I'll (eventually) adapt this patch to
the new codebase. Or feel free to rebase against next.

The code itself looks good, I have no style nits with it.
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel