Archive of RubyForge sup-devel mailing list
 help / color / mirror / Atom feed
From: Rich Lane <rlane@club.cc.cmu.edu>
To: Sascha Silbe <sascha-pgp@silbe.org>
Cc: sup-devel <sup-devel@rubyforge.org>
Subject: Re: [sup-devel] [PATCH] don't leak fds for mbox sources
Date: Mon, 12 Jul 2010 22:23:46 -0400	[thread overview]
Message-ID: <1278987576-sup-9788@zyrg.net> (raw)
In-Reply-To: <1278609322-1401-1-git-send-email-sascha-pgp@silbe.org>

This patch also won't apply once the source rewrite is merged. It's
definitely a good idea though, so I'll (eventually) adapt this patch to
the new codebase. Or feel free to rebase against next.

The code itself looks good, I have no style nits with it.
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel


  reply	other threads:[~2010-07-13  2:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-08 17:15 Sascha Silbe
2010-07-13  2:23 ` Rich Lane [this message]
2011-01-18 17:59   ` [sup-devel] [PATCH v2] " Sascha Silbe
2011-01-19  3:37     ` Rich Lane
  -- strict thread matches above, loose matches on Subject: below --
2010-07-03 11:06 [sup-devel] [PATCH] " Sascha Silbe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1278987576-sup-9788@zyrg.net \
    --to=rlane@club.cc.cmu.edu \
    --cc=sascha-pgp@silbe.org \
    --cc=sup-devel@rubyforge.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox