From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.204.141.209 with SMTP id n17cs38875bku; Thu, 1 Jul 2010 13:16:10 -0700 (PDT) Received: by 10.231.124.227 with SMTP id v35mr10635239ibr.185.1278015369260; Thu, 01 Jul 2010 13:16:09 -0700 (PDT) Return-Path: Received: from rubyforge.org (rubyforge.org [205.234.109.19]) by mx.google.com with ESMTP id f32si13790007ibk.7.2010.07.01.13.16.08; Thu, 01 Jul 2010 13:16:09 -0700 (PDT) Received-SPF: pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19; Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-devel-bounces@rubyforge.org Received: from rubyforge.org (rubyforge.org [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id BAF80185836D; Thu, 1 Jul 2010 16:16:07 -0400 (EDT) Received: from www.cquest.utoronto.ca (www.cquest.utoronto.ca [192.82.128.5]) by rubyforge.org (Postfix) with ESMTP id 5744B1858346 for ; Thu, 1 Jul 2010 16:11:08 -0400 (EDT) Received: from pinkfloyd.chass.utoronto.ca ([128.100.160.254]:36644 ident=93) by www.cquest.utoronto.ca with esmtp (Exim 4.43) id 1OUQ6G-0004zk-2N for sup-devel@rubyforge.org; Thu, 01 Jul 2010 16:11:08 -0400 Received: from bwalton by pinkfloyd.chass.utoronto.ca with local (Exim 4.63) (envelope-from ) id 1OUQ6G-0005A2-1X for sup-devel@rubyforge.org; Thu, 01 Jul 2010 16:11:08 -0400 From: Ben Walton To: sup-devel In-reply-to: <1278012648-sup-257@twin.sascha.silbe.org> References: <1277992093-10600-1-git-send-email-sascha-pgp@silbe.org> <1277994760-sup-4189@pinkfloyd.chass.utoronto.ca> <1278012648-sup-257@twin.sascha.silbe.org> Date: Thu, 01 Jul 2010 16:11:08 -0400 Message-Id: <1278015019-sup-7327@pinkfloyd.chass.utoronto.ca> User-Agent: Sup/git Subject: Re: [sup-devel] [PATCH] parse_header: don't use empty or invalid Message-ID header X-BeenThere: sup-devel@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Sup developer discussion List-Id: Sup developer discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: sup-devel-bounces@rubyforge.org Errors-To: sup-devel-bounces@rubyforge.org Excerpts from Sascha Silbe's message of Thu Jul 01 15:34:47 -0400 2010: > I just commented out a line that was only useful in combination with > the line directly below it that was already commented out. If you > prefer I can remove both of them instead (or do the change in a > separate patch). I'd resubmit with the lines removed. It keeps the history cleaner. Up to you of course, it's just my own preference I'm putting forward. Thanks -Ben -- Ben Walton Systems Programmer - CHASS University of Toronto C:416.407.5610 | W:416.978.4302 _______________________________________________ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel