From: Ben Walton <bwalton@artsci.utoronto.ca>
To: sup-devel <sup-devel@rubyforge.org>
Subject: Re: [sup-devel] [PATCH] parse_header: don't use empty or invalid Message-ID header
Date: Thu, 01 Jul 2010 16:11:08 -0400 [thread overview]
Message-ID: <1278015019-sup-7327@pinkfloyd.chass.utoronto.ca> (raw)
In-Reply-To: <1278012648-sup-257@twin.sascha.silbe.org>
Excerpts from Sascha Silbe's message of Thu Jul 01 15:34:47 -0400 2010:
> I just commented out a line that was only useful in combination with
> the line directly below it that was already commented out. If you
> prefer I can remove both of them instead (or do the change in a
> separate patch).
I'd resubmit with the lines removed. It keeps the history cleaner.
Up to you of course, it's just my own preference I'm putting forward.
Thanks
-Ben
--
Ben Walton
Systems Programmer - CHASS
University of Toronto
C:416.407.5610 | W:416.978.4302
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
next prev parent reply other threads:[~2010-07-01 20:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-01 13:48 Sascha Silbe
2010-07-01 14:33 ` Ben Walton
2010-07-01 19:34 ` Sascha Silbe
2010-07-01 20:11 ` Ben Walton [this message]
2010-07-03 10:39 ` Sascha Silbe
2010-07-03 2:32 ` Rich Lane
2010-07-03 10:35 ` Sascha Silbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278015019-sup-7327@pinkfloyd.chass.utoronto.ca \
--to=bwalton@artsci.utoronto.ca \
--cc=sup-devel@rubyforge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox