From mboxrd@z Thu Jan  1 00:00:00 1970
Received: by 10.204.141.209 with SMTP id n17cs24628bku;
        Thu, 1 Jul 2010 07:37:56 -0700 (PDT)
Received: by 10.231.17.141 with SMTP id s13mr10714173iba.149.1277995075138;
        Thu, 01 Jul 2010 07:37:55 -0700 (PDT)
Return-Path: <sup-devel-bounces@rubyforge.org>
Received: from rubyforge.org (rubyforge.org [205.234.109.19])
        by mx.google.com with ESMTP id bg33si2893600ibb.100.2010.07.01.07.37.54;
        Thu, 01 Jul 2010 07:37:54 -0700 (PDT)
Received-SPF: pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19;
Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-devel-bounces@rubyforge.org
Received: from rubyforge.org (rubyforge.org [127.0.0.1])
	by rubyforge.org (Postfix) with ESMTP id 21BA91858378;
	Thu,  1 Jul 2010 10:37:54 -0400 (EDT)
Received: from www.cquest.utoronto.ca (www.cquest.utoronto.ca [192.82.128.5])
	by rubyforge.org (Postfix) with ESMTP id B7CFF1858361
	for <sup-devel@rubyforge.org>; Thu,  1 Jul 2010 10:33:22 -0400 (EDT)
Received: from pinkfloyd.chass.utoronto.ca ([128.100.160.254]:60746 ident=93)
	by www.cquest.utoronto.ca with esmtp (Exim 4.43) id 1OUKpO-0004Do-DA
	for sup-devel@rubyforge.org; Thu, 01 Jul 2010 10:33:22 -0400
Received: from bwalton by pinkfloyd.chass.utoronto.ca with local (Exim 4.63)
	(envelope-from <bwalton@cquest.utoronto.ca>) id 1OUKpO-0003Tg-Bz
	for sup-devel@rubyforge.org; Thu, 01 Jul 2010 10:33:22 -0400
From: Ben Walton <bwalton@artsci.utoronto.ca>
To: sup-devel <sup-devel@rubyforge.org>
In-reply-to: <1277992093-10600-1-git-send-email-sascha-pgp@silbe.org>
References: <1277992093-10600-1-git-send-email-sascha-pgp@silbe.org>
Date: Thu, 01 Jul 2010 10:33:22 -0400
Message-Id: <1277994760-sup-4189@pinkfloyd.chass.utoronto.ca>
User-Agent: Sup/git
Subject: Re: [sup-devel] [PATCH] parse_header: don't use empty or invalid
	Message-ID header
X-BeenThere: sup-devel@rubyforge.org
X-Mailman-Version: 2.1.12
Precedence: list
Reply-To: Sup developer discussion <sup-devel@rubyforge.org>
List-Id: Sup developer discussion <sup-devel.rubyforge.org>
List-Unsubscribe: <http://rubyforge.org/mailman/options/sup-devel>,
	<mailto:sup-devel-request@rubyforge.org?subject=unsubscribe>
List-Archive: <http://rubyforge.org/pipermail/sup-devel>
List-Post: <mailto:sup-devel@rubyforge.org>
List-Help: <mailto:sup-devel-request@rubyforge.org?subject=help>
List-Subscribe: <http://rubyforge.org/mailman/listinfo/sup-devel>,
	<mailto:sup-devel-request@rubyforge.org?subject=subscribe>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: sup-devel-bounces@rubyforge.org
Errors-To: sup-devel-bounces@rubyforge.org

Excerpts from Sascha Silbe's message of Thu Jul 01 09:48:13 -0400 2010:

Hi Sascha,

> +      #from = header["from"]

This patch looks good, but why include the commented line?

Thanks
-Ben
--
Ben Walton
Systems Programmer - CHASS
University of Toronto
C:416.407.5610 | W:416.978.4302

_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel