From: Sascha Silbe <sascha-ml-email-sup-devel@silbe.org>
To: sup-devel <sup-devel@rubyforge.org>
Subject: [sup-devel] Will sup blow up after adding 10k sources?
Date: Tue, 29 Jun 2010 08:54:22 +0000 [thread overview]
Message-ID: <1277801600-sup-3476@twin.sascha.silbe.org> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 1150 bytes --]
Hi!
While fixing the sup-dump vs. default sent source bug (see posted patch) I stumbled over the following pieces of code:
1. SentManager uses source_id of 9998 for the default sent source
(lib/sup/sent.rb:52)
2. DraftManager uses a fixed source_id of 9999
(lib/sup/draft.rb:13,49)
3. SourceManager skips the source_id of SentManager and DraftManager
while computing the id for a new source (lib/sup/source.rb:203)
Does that mean sup will blow up once I have more than ~10k sources? I'm already at > 5k sources (containing > 680k messages, took > 2 days to import), so this isn't just an academic exercise...
Wouldn't it be better to (*) use small fixed source ids for SentManager/DraftManager and let SourceManager start above a number of reserved ids (say: 50)? Is there something in sup that depends on the non-special source ids not to have "holes" (or will waste resources in that case)?
Another approach would be to make the SentManager/DraftManager source ids dynamic and add them to sources.yaml.
Sascha
(*) Read: Would you accept a patch that implements that new logic?
--
http://sascha.silbe.org/
http://www.infra-silbe.de/
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
[-- Attachment #2: Type: text/plain, Size: 143 bytes --]
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
next reply other threads:[~2010-06-29 8:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-29 8:54 Sascha Silbe [this message]
2010-06-29 13:15 ` Ben Walton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1277801600-sup-3476@twin.sascha.silbe.org \
--to=sascha-ml-email-sup-devel@silbe.org \
--cc=sascha-ml-reply-to-2010-2@silbe.org \
--cc=sup-devel@rubyforge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox