From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.204.134.218 with SMTP id k26cs41835bkt; Wed, 9 Jun 2010 06:15:29 -0700 (PDT) Received: by 10.231.157.205 with SMTP id c13mr46321ibx.53.1276089328089; Wed, 09 Jun 2010 06:15:28 -0700 (PDT) Return-Path: Received: from rubyforge.org (rubyforge.org [205.234.109.19]) by mx.google.com with ESMTP id c1si10608099ibg.6.2010.06.09.06.15.27; Wed, 09 Jun 2010 06:15:28 -0700 (PDT) Received-SPF: pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19; Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-devel-bounces@rubyforge.org; dkim=neutral (body hash did not verify) header.i=@gmail.com Received: from rubyforge.org (rubyforge.org [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id 2A7A43C8042; Wed, 9 Jun 2010 09:15:27 -0400 (EDT) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by rubyforge.org (Postfix) with ESMTP id DD02D1858366 for ; Wed, 9 Jun 2010 09:15:18 -0400 (EDT) Received: by wwg30 with SMTP id 30so959527wwg.23 for ; Wed, 09 Jun 2010 06:15:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:subject:from:to :in-reply-to:references:date:message-id:user-agent :content-transfer-encoding:content-type:mime-version; bh=wSTBN3if6mFC21QmJL/RoamACEcpc2JouUtC0SFuQas=; b=NjmlpVUfIFXWjuN0i2lmDoypJW7Vudxh0hvy+ww0snMg3ENtc3puOdo1fVt0rF72xo P86l5AKvTKYGnbAfzkahp+bGJxdzIJozOHDkAXin2MXE8H1eDCmdk8O5VcbMZB2WyPZU 1wvt6YgH/ylttLajBh8bl8qIady6FdBaiZ1EM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:subject:from:to:in-reply-to:references:date:message-id :user-agent:content-transfer-encoding:content-type:mime-version; b=QVtnpDLBZylVyLoihjWdRz2gMS7BvH1Ga4f8hx53fV6x4GUS/PRg2KWinNTFAoUL5b cnwngOomPXU8hlQcGPXwyqARKFFTOOQIVEubvsKLB0mvK607BdUcAgDILiUANkFxIVIy bV0hmh0wlrGr89qC1nLgdXpQmts34yHZ259NA= Received: by 10.227.69.208 with SMTP id a16mr12259512wbj.193.1276089312861; Wed, 09 Jun 2010 06:15:12 -0700 (PDT) Received: from localhost (mut38-4-82-233-117-144.fbx.proxad.net [82.233.117.144]) by mx.google.com with ESMTPS id t70sm2965083weq.2.2010.06.09.06.15.11 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 09 Jun 2010 06:15:12 -0700 (PDT) From: Damien Leone To: sup-devel In-reply-to: <1276087951-sup-7816@mailer> References: <1276087951-sup-7816@mailer> Date: Wed, 09 Jun 2010 15:15:11 +0200 Message-Id: <1276089233-sup-510@mailer> User-Agent: Sup/git Content-Transfer-Encoding: 8bit Content-Type: multipart/mixed; boundary="=-1276089311-69397-6754-2799-1-=" MIME-Version: 1.0 Subject: Re: [sup-devel] [PATCHES] reply-mode, signatures and account selector X-BeenThere: sup-devel@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Sup developer discussion List-Id: Sup developer discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: sup-devel-bounces@rubyforge.org Errors-To: sup-devel-bounces@rubyforge.org --=-1276089311-69397-6754-2799-1-= Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline I noticed an error in the third patch. Please consider the one attached to *this* email. Regards, Excerpts from Damien Leone's message of mer. juin 09 14:53:16 +0200 2010: > Sup guys, > > Three patches are attached to this email, the commit messages should > be self explanatory but here are some more details: > > As the first patch changes the way headers are handled in reply-mode > there is a regression in the before-edit hook possibilities. > Before, we could write something like: > > if header["Cc"] == "foo" > header["Bcc"] = "bar" > end > > Hence, switching the reply-to type using the selector would have > changed the Bcc field if a type using Cc was selected. > > This would be no longer possible since there is now only one "set" of > headers running the hook, however if you properly wrote your reply-to > hook you can select the reply type you want and the previous code > will be working as expected. > > On the other hand (in my opinion), the reply-mode now handles better > its job, that is to say changing To and Cc without interfering with > other fields that might have been edited manually by the user. > > I asked rlane about this on IRC: > > what is the reason for the before-edit hook being runned on @bodies and @header for each Reply-To types? > > that's so that when you switch reply-to type the right signature/etc is displayed > > I see no regression regarding this in the patch, so it should be okay. > > Other patches add an account selector in edit-mode (it is useful to me > and I saw requests for such a feature) and a better signature handling > regarding the edit_signature option. > > Regards, -- Damien Leone Web: http://dleone.fensalir.fr/ GPG: 0x82EB4DDF --=-1276089311-69397-6754-2799-1-= Content-Disposition: attachment; filename="0003-edit-mode-change-the-way-signatures-are-handled.patch" Content-Type: application/octet-stream; name="0003-edit-mode-change-the-way-signatures-are-handled.patch" Content-Transfer-Encoding: base64 RnJvbSBlZjkyZTU0ZTBjZWExMmZiNGFkNDJhMTg4MDhkNDkwZDZjZDRlMDg0 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBEYW1pZW4gTGVvbmUg PGRhbWllbi5sZW9uZUBmZW5zYWxpci5mcj4KRGF0ZTogV2VkLCA5IEp1biAy MDEwIDE1OjEyOjE1ICswMjAwClN1YmplY3Q6IFtQQVRDSCAzLzNdIGVkaXQt bW9kZTogY2hhbmdlIHRoZSB3YXkgc2lnbmF0dXJlcyBhcmUgaGFuZGxlZAoK VGhlIGN1cnJlbnQgc2lnbmF0dXJlcyBoYW5kbGluZyB3YXMgbm90IHN1aXRh YmxlIGZvciBhY2NvdW50IGNoYW5naW5nCmluIGVkaXQtbW9kZS4gSXQgd2Fz IHdvcmtpbmcgZmluZSB3aGVuIHRoZSBlZGl0X3NpZ25hdHVyZSBvcHRpb24g d2FzCmZhbHNlLCBidXQgaXQgY291bGQgaGF2ZSBhIGJldHRlciBiZWhhdmlv dXIgaWYgdGhpcyBvcHRpb24gd2FzCmVuYWJsZWQuCgpUaGlzIGNvbW1pdCB0 cmllcyB0byBkbyB0aGlzIGJ5IGFwcGVuZGluZyB0aGUgc2lnbmF0dXJlIHRv IHRoZSBib2R5CnRleHQgaWYgdGhlIGVkaXRfc2lnbmF0dXJlIGlzIHRydWUs IHRoZW4gYWZ0ZXIgZWRpdGluZyB0aGUgbWVzc2FnZSBpdApjaGVja3MgaWYg dGhlIHNpZ25hdHVyZSBoYXMgYmVlbiBtb2RpZmllZCBieSBjb21wYXJpbmcg dGhlIGVuZCBvZiB0aGUKZmlsZSB0byB0aGUgY3VycmVudCBhY2NvdW50J3Mg c2lnbmF0dXJlLiBJZiBpdCBoYXMgYmVlbiBlZGl0ZWQgdGhlbiB3ZQpzdGlj ayB0byBpdCBieSBzZXR0aW5nIEBzaWdfZWRpdGVkIHRvIHRydWUsIG90aGVy d2lzZSB0aGUgc2lnbmF0dXJlCndpbGwgc3RpbGwgYmUgYXV0b21hdGljYWxs eSBjaGFuZ2VkIGlmIGFub3RoZXIgYWNjb3VudCBpcyBzZWxlY3RlZC4KLS0t CiBsaWIvc3VwL21vZGVzL2VkaXQtbWVzc2FnZS1tb2RlLnJiIHwgICAyMSAr KysrKysrKysrKysrKysrKystLS0KIDEgZmlsZXMgY2hhbmdlZCwgMTggaW5z ZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saWIv c3VwL21vZGVzL2VkaXQtbWVzc2FnZS1tb2RlLnJiIGIvbGliL3N1cC9tb2Rl cy9lZGl0LW1lc3NhZ2UtbW9kZS5yYgppbmRleCBkZDg5YjdiLi42NzJmZDJi IDEwMDY0NAotLS0gYS9saWIvc3VwL21vZGVzL2VkaXQtbWVzc2FnZS1tb2Rl LnJiCisrKyBiL2xpYi9zdXAvbW9kZXMvZWRpdC1tZXNzYWdlLW1vZGUucmIK QEAgLTgxLDcgKzgxLDcgQEAgRU9TCiAgICAgQGhlYWRlcl9saW5lcyA9IFtd CiAKICAgICBAYm9keSA9IG9wdHMuZGVsZXRlKDpib2R5KSB8fCBbXQotICAg IEBib2R5ICs9IHNpZ19saW5lcyBpZiAkY29uZmlnWzplZGl0X3NpZ25hdHVy ZV0gJiYgIW9wdHMuZGVsZXRlKDpoYXZlX3NpZ25hdHVyZSkKKyAgICBAc2ln X2VkaXRlZCA9IGZhbHNlCiAKICAgICBpZiBvcHRzWzphdHRhY2htZW50c10K ICAgICAgIEBhdHRhY2htZW50cyA9IG9wdHNbOmF0dGFjaG1lbnRzXS52YWx1 ZXMKQEAgLTE2NiwxMiArMTY2LDE0IEBAIEVPUwogICBkZWYgZWRpdF9zdWJq ZWN0OyBlZGl0X2ZpZWxkICJTdWJqZWN0IiBlbmQKIAogICBkZWYgZWRpdF9t ZXNzYWdlCisgICAgc2lnID0gc2lnX2xpbmVzLmpvaW4oIlxuIikKICAgICBv bGRfZnJvbSA9IEBoZWFkZXJbIkZyb20iXSBpZiBAYWNjb3VudF9zZWxlY3Rv cgogCiAgICAgQGZpbGUgPSBUZW1wZmlsZS5uZXcgInN1cC4je3NlbGYuY2xh c3MubmFtZS5nc3ViKC8uKjo6LywgJycpLmNhbWVsX3RvX2h5cGh5fSIKICAg ICBAZmlsZS5wdXRzIGZvcm1hdF9oZWFkZXJzKEBoZWFkZXIgLSBOT05fRURJ VEFCTEVfSEVBREVSUykuZmlyc3QKICAgICBAZmlsZS5wdXRzCiAgICAgQGZp bGUucHV0cyBAYm9keS5qb2luKCJcbiIpCisgICAgQGZpbGUucHV0cyBzaWcg aWYgKCRjb25maWdbOmVkaXRfc2lnbmF0dXJlXSBhbmQgIUBzaWdfZWRpdGVk KQogICAgIEBmaWxlLmNsb3NlCiAKICAgICBlZGl0b3IgPSAkY29uZmlnWzpl ZGl0b3JdIHx8IEVOVlsnRURJVE9SJ10gfHwgIi91c3IvYmluL3ZpIgpAQCAt MTg1LDYgKzE4NywxOSBAQCBFT1MKICAgICBoZWFkZXIsIEBib2R5ID0gcGFy c2VfZmlsZSBAZmlsZS5wYXRoCiAgICAgQGhlYWRlciA9IGhlYWRlciAtIE5P Tl9FRElUQUJMRV9IRUFERVJTCiAKKyAgICBpZiAkY29uZmlnWzplZGl0X3Np Z25hdHVyZV0KKyAgICAgIHBib2R5ID0gQGJvZHkuam9pbigiXG4iKQorICAg ICAgYmxlbiA9IHBib2R5Lmxlbmd0aAorICAgICAgc2xlbiA9IHNpZy5sZW5n dGgKKworICAgICAgaWYgYmxlbiA+IHNsZW4gYW5kIHBib2R5W2JsZW4tc2xl bi4uYmxlbl0gPT0gc2lnCisgICAgICAgIEBzaWdfZWRpdGVkID0gZmFsc2UK KyAgICAgICAgQGJvZHkgPSBwYm9keVswLi5ibGVuLXNsZW5dLnNwbGl0KCJc biIpCisgICAgICBlbHNlCisgICAgICAgIEBzaWdfZWRpdGVkID0gdHJ1ZQor ICAgICAgZW5kCisgICAgZW5kCisKICAgICBpZiBAYWNjb3VudF9zZWxlY3Rv ciBhbmQgQGhlYWRlclsiRnJvbSJdICE9IG9sZF9mcm9tCiAgICAgICBAYWNj b3VudF91c2VyID0gQGhlYWRlclsiRnJvbSJdCiAgICAgICBAYWNjb3VudF9z ZWxlY3Rvci5zZXRfdG8gbmlsCkBAIC0yODgsNyArMzAzLDcgQEAgcHJvdGVj dGVkCiAgIGRlZiByZWdlbl90ZXh0CiAgICAgaGVhZGVyLCBAaGVhZGVyX2xp bmVzID0gZm9ybWF0X2hlYWRlcnMoQGhlYWRlciAtIE5PTl9FRElUQUJMRV9I RUFERVJTKSArIFsiIl0KICAgICBAdGV4dCA9IGhlYWRlciArIFsiIl0gKyBA Ym9keQotICAgIEB0ZXh0ICs9IHNpZ19saW5lcyB1bmxlc3MgJGNvbmZpZ1s6 ZWRpdF9zaWduYXR1cmVdCisgICAgQHRleHQgKz0gc2lnX2xpbmVzIHVubGVz cyBAc2lnX2VkaXRlZAogICAgIAogICAgIEBhdHRhY2htZW50X2xpbmVzX29m ZnNldCA9IDAKIApAQCAtMzk0LDcgKzQwOSw3IEBAIHByb3RlY3RlZAogICAg IG0gPSBSTWFpbDo6TWVzc2FnZS5uZXcKICAgICBtLmhlYWRlclsiQ29udGVu dC1UeXBlIl0gPSAidGV4dC9wbGFpbjsgY2hhcnNldD0jeyRlbmNvZGluZ30i CiAgICAgbS5ib2R5ID0gQGJvZHkuam9pbigiXG4iKQotICAgIG0uYm9keSAr PSBzaWdfbGluZXMuam9pbigiXG4iKSB1bmxlc3MgJGNvbmZpZ1s6ZWRpdF9z aWduYXR1cmVdCisgICAgbS5ib2R5ICs9ICJcbiIgKyBzaWdfbGluZXMuam9p bigiXG4iKSB1bmxlc3MgQHNpZ19lZGl0ZWQKICAgICAjIyBib2R5IG11c3Qg ZW5kIGluIGEgbmV3bGluZSBvciBHUEcgc2lnbmF0dXJlcyB3aWxsIGJlIFdS T05HIQogICAgIG0uYm9keSArPSAiXG4iIHVubGVzcyBtLmJvZHkgPX4gL1xu XFovCiAKLS0gCjEuNy4xCgo= --=-1276089311-69397-6754-2799-1-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel --=-1276089311-69397-6754-2799-1-=--