From: Todd Eisenberger <sup-bugs@masanjin.net>
To: sup-devel@rubyforge.org
Subject: [sup-devel] [issue100] GPG Signing Bug
Date: Sat, 08 May 2010 03:18:27 +0000 [thread overview]
Message-ID: <1273288706.87.0.318581427994.issue100@masanjin.net> (raw)
In-Reply-To: <1273288706.87.0.318581427994.issue100@masanjin.net>
[-- Attachment #1: Type: text/plain, Size: 852 bytes --]
New submission from Todd Eisenberger <teisenbe@andrew.cmu.edu>:
After having a few messages fail verification on the recipient end, I discovered
that sup is not compliant with the RFC for signing email with PGP/GPG. RFC2015
section 3 indicates that signed messages must be sent in a 7-bit format such as
base64 or quoted-printable. Attached is a patch to provide compliance by
converting to base64 when crypto is used. Note: I am unfamiliar with the code
base, so it is possible this patch is not correct.
----------
files: gpg.patch
messages: 227
nosy: teisenbe
priority: bug
ruby_version: 1.8.7
status: unread
sup_version: git
title: GPG Signing Bug
_________________________________________
Sup issue tracker <sup-bugs@masanjin.net>
<http://masanjin.net/sup-bugs/issue100>
_________________________________________
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gpg.patch --]
[-- Type: text/x-patch, Size: 881 bytes --]
diff --git a/lib/sup/modes/edit-message-mode.rb b/lib/sup/modes/edit-message-mode.rb
index c1537ae..a73a146 100644
--- a/lib/sup/modes/edit-message-mode.rb
+++ b/lib/sup/modes/edit-message-mode.rb
@@ -382,6 +382,8 @@ protected
if @crypto_selector && @crypto_selector.val != :none
from_email = Person.from_address(@header["From"]).email
to_email = [@header["To"], @header["Cc"], @header["Bcc"]].flatten.compact.map { |p| Person.from_address(p).email }
+ m.header["Content-Transfer-Encoding"] = 'base64'
+ m.body = [m.body].pack('m')
m = CryptoManager.send @crypto_selector.val, from_email, to_email, m
end
@@ -401,7 +403,6 @@ protected
m.header["Date"] = date.rfc2822
m.header["Message-Id"] = @message_id
m.header["User-Agent"] = "Sup/#{Redwood::VERSION}"
- m.header["Content-Transfer-Encoding"] = '8bit'
m
end
[-- Attachment #3: Type: text/plain, Size: 143 bytes --]
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
next parent reply other threads:[~2010-05-08 3:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-08 3:18 Todd Eisenberger [this message]
2010-05-11 4:18 ` Rich Lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273288706.87.0.318581427994.issue100@masanjin.net \
--to=sup-bugs@masanjin.net \
--cc=sup-devel@rubyforge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox