From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.86.87.8 with SMTP id k8cs82742fgb; Fri, 12 Mar 2010 02:22:41 -0800 (PST) Received: by 10.229.44.5 with SMTP id y5mr3479658qce.11.1268389360280; Fri, 12 Mar 2010 02:22:40 -0800 (PST) Return-Path: Received: from rubyforge.org (rubyforge.org [205.234.109.19]) by mx.google.com with ESMTP id 2si2567892qwi.1.2010.03.12.02.22.39; Fri, 12 Mar 2010 02:22:40 -0800 (PST) Received-SPF: pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19; Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-devel-bounces@rubyforge.org Received: from rubyforge.org (rubyforge.org [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id 7EF6B18582F3; Fri, 12 Mar 2010 05:22:39 -0500 (EST) Received: from twice-irc.de (mx2.twice-irc.de [79.140.35.195]) by rubyforge.org (Postfix) with ESMTP id E589718582EE for ; Fri, 12 Mar 2010 05:17:46 -0500 (EST) Received: from midna.zekjur.net (midna.zekjur.net [IPv6:2001:4d88:1008:4242:21c:c0ff:fe7e:4776]) by twice-irc.de (Postfix) with ESMTPSA id A8D9E1665C5; Fri, 12 Mar 2010 11:17:45 +0100 (CET) Received: by midna.zekjur.net (Postfix, from userid 101) id 00E3424059; Fri, 12 Mar 2010 11:17:44 +0100 (CET) From: Michael Stapelberg To: Rich Lane In-reply-to: <1268366964-sup-2310@zyrg.net> References: <1264026370-sup-8092@midna.zekjur.net> <1267295207-sup-7090@zyrg.net> <1268175393-sup-8314@midna.zekjur.net> <1268366964-sup-2310@zyrg.net> Date: Fri, 12 Mar 2010 11:17:44 +0100 Message-Id: <1268388251-sup-2106@midna.zekjur.net> User-Agent: Sup/git Content-Transfer-Encoding: 8bit Content-Type: multipart/mixed; boundary="=-1268389064-978593-16972-349-1-=" MIME-Version: 1.0 Cc: sup-devel Subject: Re: [sup-devel] [PATCH] Use multiple body arrays when calling before-edit for each reply type X-BeenThere: sup-devel@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Sup developer discussion List-Id: Sup developer discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: sup-devel-bounces@rubyforge.org Errors-To: sup-devel-bounces@rubyforge.org --=-1268389064-978593-16972-349-1-= Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Hi Rich, Excerpts from Rich Lane's message of Fr Mär 12 05:20:52 +0100 2010: > lib/sup/modes/reply-mode.rb: > > + @bodies[k] = Array.new(body) > > Why is the body in an array? That was left over while refactoring. It isn’t necessary. > The idiomatic way to write this is: > self.body = @bodies[@type_selector.val] unless @edited Alright, changed. > lib/sup/modes/reply-mode.rb: > > + if new_body != @bodies[@type_selector.val] > > + @bodies[@type_selector.val] = new_body > > + @edited = true > > + end > > Is there a reason we can't do this unconditionally? Yes, I wanted to avoid setting the @edited flag if the user exited the editor without making any changes. That way, he can benefit from the changing bodies for a longer time. Updated patch attached. Best regards, Michael --=-1268389064-978593-16972-349-1-= Content-Disposition: attachment; filename="0001-Use-multiple-body-arrays-when-calling-before-edit-fo.patch" Content-Type: application/octet-stream; name="0001-Use-multiple-body-arrays-when-calling-before-edit-fo.patch" Content-Transfer-Encoding: base64 RnJvbSA1NjYxZjkwNGZkNjZlMWE1ZjI5NGEyZmI2MDI2OTE5NDc4NjBjZDk3 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNaWNoYWVsIFN0YXBl bGJlcmcgPG1pY2hhZWxAc3RhcGVsYmVyZy5kZT4KRGF0ZTogVHVlLCA5IE1h ciAyMDEwIDIzOjU2OjAyICswMTAwClN1YmplY3Q6IFtQQVRDSF0gVXNlIG11 bHRpcGxlIGJvZHkgYXJyYXlzIHdoZW4gY2FsbGluZyBiZWZvcmUtZWRpdCBm b3IgZWFjaCByZXBseSB0eXBlCgpUaGlzIGFsbG93cyBmb3IgYmVmb3JlLWVk aXQgaG9va3Mgd2hpY2ggbW9kaWZ5IHRoZSBib2R5IG9mIHRoZSBtZXNzYWdl CmJhc2VkIG9uIHRoZSBkaWZmZXJlbnQgaGVhZGVycyAocHJldmlvdXNseSwg dGhleSBjb3VsZCBvbmx5IG1vZGlmeQpoZWFkZXJzKS4KCkFzIGFuIGV4YW1w bGUsIEkgdXNlIGl0IHRvIHNpZ24gbWFpbCBpbiBlbmdsaXNoIGlmIG9uZSBv ZiB0aGUgcmVjaXBpZW50cwoobm90ICp0aGUqIHJlY2lwaWVudCwgYnV0IG9u ZSBvZiB0aGVtKSBpcyBzcGVha2luZyBlbmdsaXNoLgotLS0KIGxpYi9zdXAv bW9kZXMvcmVwbHktbW9kZS5yYiB8ICAgMTMgKysrKysrKysrKystLQogMSBm aWxlcyBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL2xpYi9zdXAvbW9kZXMvcmVwbHktbW9kZS5yYiBi L2xpYi9zdXAvbW9kZXMvcmVwbHktbW9kZS5yYgppbmRleCAzZDM5YThhLi5i YmFjOTIyIDEwMDY0NAotLS0gYS9saWIvc3VwL21vZGVzL3JlcGx5LW1vZGUu cmIKKysrIGIvbGliL3N1cC9tb2Rlcy9yZXBseS1tb2RlLnJiCkBAIC00Miw2 ICs0Miw3IEBAIEVPUwogCiAgIGRlZiBpbml0aWFsaXplIG1lc3NhZ2UsIHR5 cGVfYXJnPW5pbAogICAgIEBtID0gbWVzc2FnZQorICAgIEBlZGl0ZWQgPSBm YWxzZQogCiAgICAgIyMgaXQncyBpbXBvcnRhbnQgdG8gcHV0IHRoaXMgZWFy bHkgYmVjYXVzZSBpdCBmb3JjZXMgYSByZWFkIG9mCiAgICAgIyMgdGhlIGZ1 bGwgaGVhZGVycyAobW9zdCBpbXBvcnRhbnRseSB0aGUgbGlzdC1wb3N0IGhl YWRlciwgaWYKQEAgLTE1MCwxMSArMTUxLDEzIEBAIEVPUwogICAgICAgICA6 cmVjaXBpZW50CiAgICAgICBlbmQpCiAKKyAgICBAYm9kaWVzID0ge30KICAg ICBAaGVhZGVycy5lYWNoIGRvIHxrLCB2fAotICAgICAgSG9va01hbmFnZXIu cnVuICJiZWZvcmUtZWRpdCIsIDpoZWFkZXIgPT4gdiwgOmJvZHkgPT4gYm9k eQorICAgICAgQGJvZGllc1trXSA9IGJvZHkKKyAgICAgIEhvb2tNYW5hZ2Vy LnJ1biAiYmVmb3JlLWVkaXQiLCA6aGVhZGVyID0+IHYsIDpib2R5ID0+IEBi b2RpZXNba10KICAgICBlbmQKIAotICAgIHN1cGVyIDpoZWFkZXIgPT4gQGhl YWRlcnNbQHR5cGVfc2VsZWN0b3IudmFsXSwgOmJvZHkgPT4gYm9keSwgOnR3 aWRkbGVzID0+IGZhbHNlCisgICAgc3VwZXIgOmhlYWRlciA9PiBAaGVhZGVy c1tAdHlwZV9zZWxlY3Rvci52YWxdLCA6Ym9keSA9PiBAYm9kaWVzW0B0eXBl X3NlbGVjdG9yLnZhbF0sIDp0d2lkZGxlcyA9PiBmYWxzZQogICAgIGFkZF9z ZWxlY3RvciBAdHlwZV9zZWxlY3RvcgogICBlbmQKIApAQCAtMTY0LDYgKzE2 Nyw3IEBAIHByb3RlY3RlZAogICAgIHN1cGVyCiAgICAgaWYgQGhlYWRlcnNb QHR5cGVfc2VsZWN0b3IudmFsXSAhPSBzZWxmLmhlYWRlcgogICAgICAgc2Vs Zi5oZWFkZXIgPSBAaGVhZGVyc1tAdHlwZV9zZWxlY3Rvci52YWxdCisgICAg ICBzZWxmLmJvZHkgPSBAYm9kaWVzW0B0eXBlX3NlbGVjdG9yLnZhbF0gdW5s ZXNzIEBlZGl0ZWQKICAgICAgIHVwZGF0ZQogICAgIGVuZAogICBlbmQKQEAg LTE3Miw2ICsxNzYsNyBAQCBwcm90ZWN0ZWQKICAgICBzdXBlcgogICAgIGlm IEBoZWFkZXJzW0B0eXBlX3NlbGVjdG9yLnZhbF0gIT0gc2VsZi5oZWFkZXIK ICAgICAgIHNlbGYuaGVhZGVyID0gQGhlYWRlcnNbQHR5cGVfc2VsZWN0b3Iu dmFsXQorICAgICAgc2VsZi5ib2R5ID0gQGJvZGllc1tAdHlwZV9zZWxlY3Rv ci52YWxdIHVubGVzcyBAZWRpdGVkCiAgICAgICB1cGRhdGUKICAgICBlbmQK ICAgZW5kCkBAIC0xODgsNiArMTkzLDEwIEBAIHByb3RlY3RlZAogICBlbmQK IAogICBkZWYgaGFuZGxlX25ld190ZXh0IG5ld19oZWFkZXIsIG5ld19ib2R5 CisgICAgaWYgbmV3X2JvZHkgIT0gQGJvZGllc1tAdHlwZV9zZWxlY3Rvci52 YWxdCisgICAgICBAYm9kaWVzW0B0eXBlX3NlbGVjdG9yLnZhbF0gPSBuZXdf Ym9keQorICAgICAgQGVkaXRlZCA9IHRydWUKKyAgICBlbmQKICAgICBvbGRf aGVhZGVyID0gQGhlYWRlcnNbQHR5cGVfc2VsZWN0b3IudmFsXQogICAgIGlm IG5ld19oZWFkZXIuc2l6ZSAhPSBvbGRfaGVhZGVyLnNpemUgfHwgb2xkX2hl YWRlci5hbnk/IHsgfGssIHZ8IG5ld19oZWFkZXJba10gIT0gdiB9CiAgICAg ICBAdHlwZV9zZWxlY3Rvci5zZXRfdG8gOnVzZXIKLS0gCjEuNi41Cgo= --=-1268389064-978593-16972-349-1-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel --=-1268389064-978593-16972-349-1-=--