From mboxrd@z Thu Jan  1 00:00:00 1970
Received: by 10.86.87.8 with SMTP id k8cs76568fgb;
        Thu, 11 Mar 2010 20:43:44 -0800 (PST)
Received: by 10.224.5.72 with SMTP id 8mr209990qau.96.1268369023573;
        Thu, 11 Mar 2010 20:43:43 -0800 (PST)
Return-Path: <sup-devel-bounces@rubyforge.org>
Received: from rubyforge.org (rubyforge.org [205.234.109.19])
        by mx.google.com with ESMTP id 7si1960641qwb.20.2010.03.11.20.43.43;
        Thu, 11 Mar 2010 20:43:43 -0800 (PST)
Received-SPF: pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19;
Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-devel-bounces@rubyforge.org
Received: from rubyforge.org (rubyforge.org [127.0.0.1])
	by rubyforge.org (Postfix) with ESMTP id E4F9D158807A;
	Thu, 11 Mar 2010 23:43:42 -0500 (EST)
Received: from pion.club.cc.cmu.edu (PION.CLUB.CC.cmu.edu [128.237.157.88])
	by rubyforge.org (Postfix) with ESMTP id 2B74C1588033
	for <sup-devel@rubyforge.org>; Thu, 11 Mar 2010 23:43:39 -0500 (EST)
Received: from rlane by pion.club.cc.cmu.edu with local (Exim 4.69)
	(envelope-from <rlane@zyrg.net>)
	id 1Npwio-0007x6-Go; Thu, 11 Mar 2010 23:43:38 -0500
From: Rich Lane <rlane@club.cc.cmu.edu>
To: Michael Stapelberg <michael+sup@stapelberg.de>
In-reply-to: <1268256145-sup-8174@midna.zekjur.net>
References: <1266493070-sup-7733@midna.zekjur.net>
	<1267219197-sup-2428@zyrg.net>
	<1267276103-sup-6406@midna.zekjur.net>
	<1267293663-sup-2241@zyrg.net>
	<1267450467-sup-4411@midna.zekjur.net>
	<1267454104-sup-9569@peer.zerties.org>
	<1267462001-sup-1957@midna.zekjur.net>
	<1267465546-sup-2321@peer.zerties.org>
	<1268152912-sup-4673@midna.zekjur.net>
	<1268256145-sup-8174@midna.zekjur.net>
Date: Thu, 11 Mar 2010 23:43:38 -0500
Message-Id: <1268368142-sup-4547@zyrg.net>
User-Agent: Sup/git
Cc: sup-devel <sup-devel@rubyforge.org>
Subject: Re: [sup-devel] [PATCH] Implement inline GPG (updated)
X-BeenThere: sup-devel@rubyforge.org
X-Mailman-Version: 2.1.12
Precedence: list
Reply-To: Sup developer discussion <sup-devel@rubyforge.org>
List-Id: Sup developer discussion <sup-devel.rubyforge.org>
List-Unsubscribe: <http://rubyforge.org/mailman/options/sup-devel>,
	<mailto:sup-devel-request@rubyforge.org?subject=unsubscribe>
List-Archive: <http://rubyforge.org/pipermail/sup-devel>
List-Post: <mailto:sup-devel@rubyforge.org>
List-Help: <mailto:sup-devel-request@rubyforge.org?subject=help>
List-Subscribe: <http://rubyforge.org/mailman/listinfo/sup-devel>,
	<mailto:sup-devel-request@rubyforge.org?subject=subscribe>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: sup-devel-bounces@rubyforge.org
Errors-To: sup-devel-bounces@rubyforge.org

lib/sup/message.rb:

Since the regexes only match whole lines, why not just do string
comparisons? I'd also like those strings to be constants but I won't
insist on that. 

The body assignment should be a ternary.

I really dislike the flip-flop operator but it looks like the best way
to do this. Please package those selects into a commented Enumerable
method.

Please factor your two cases in message_to_chunks into very well
documented methods. message_to_chunks is already too complicated.
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel