From: Rich Lane <rlane@club.cc.cmu.edu>
To: Michael Stapelberg <michael+sup@stapelberg.de>
Cc: sup-devel <sup-devel@rubyforge.org>
Subject: Re: [sup-devel] [PATCH] Implement inline GPG (updated)
Date: Thu, 11 Mar 2010 23:43:38 -0500 [thread overview]
Message-ID: <1268368142-sup-4547@zyrg.net> (raw)
In-Reply-To: <1268256145-sup-8174@midna.zekjur.net>
lib/sup/message.rb:
Since the regexes only match whole lines, why not just do string
comparisons? I'd also like those strings to be constants but I won't
insist on that.
The body assignment should be a ternary.
I really dislike the flip-flop operator but it looks like the best way
to do this. Please package those selects into a commented Enumerable
method.
Please factor your two cases in message_to_chunks into very well
documented methods. message_to_chunks is already too complicated.
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
next prev parent reply other threads:[~2010-03-12 4:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-18 11:40 [sup-devel] [PATCH] Implement inline GPG Michael Stapelberg
2010-02-26 21:24 ` Rich Lane
2010-02-27 13:11 ` Michael Stapelberg
2010-02-27 18:05 ` Rich Lane
2010-03-01 13:45 ` Michael Stapelberg
2010-03-01 14:36 ` Christian Dietrich
2010-03-01 16:49 ` Michael Stapelberg
2010-03-01 17:46 ` Christian Dietrich
2010-03-09 16:43 ` [sup-devel] [PATCH] Implement inline GPG (updated) Michael Stapelberg
2010-03-10 21:23 ` Michael Stapelberg
2010-03-12 4:43 ` Rich Lane [this message]
2010-03-12 11:02 ` Michael Stapelberg
2010-03-15 5:19 ` Rich Lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268368142-sup-4547@zyrg.net \
--to=rlane@club.cc.cmu.edu \
--cc=michael+sup@stapelberg.de \
--cc=sup-devel@rubyforge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox