From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.86.87.8 with SMTP id k8cs93109fgb; Tue, 9 Mar 2010 14:58:48 -0800 (PST) Received: by 10.224.6.7 with SMTP id 7mr433279qax.241.1268175525735; Tue, 09 Mar 2010 14:58:45 -0800 (PST) Return-Path: Received: from rubyforge.org (rubyforge.org [205.234.109.19]) by mx.google.com with ESMTP id 4si15955952qwe.16.2010.03.09.14.58.45; Tue, 09 Mar 2010 14:58:45 -0800 (PST) Received-SPF: pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19; Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-devel-bounces@rubyforge.org Received: from rubyforge.org (rubyforge.org [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id 0316F158806F; Tue, 9 Mar 2010 17:58:45 -0500 (EST) Received: from twice-irc.de (mx2.twice-irc.de [79.140.35.195]) by rubyforge.org (Postfix) with ESMTP id 91C5618582D2 for ; Tue, 9 Mar 2010 17:58:34 -0500 (EST) Received: from midna.zekjur.net (midna.zekjur.net [IPv6:2001:4d88:1008:4242:21c:c0ff:fe7e:4776]) by twice-irc.de (Postfix) with ESMTPSA id C2547166635; Tue, 9 Mar 2010 23:58:33 +0100 (CET) Received: by midna.zekjur.net (Postfix, from userid 101) id 25FD024015; Tue, 9 Mar 2010 23:58:33 +0100 (CET) From: Michael Stapelberg To: Rich Lane In-reply-to: <1267295207-sup-7090@zyrg.net> References: <1264026370-sup-8092@midna.zekjur.net> <1267295207-sup-7090@zyrg.net> Date: Tue, 09 Mar 2010 23:58:33 +0100 Message-Id: <1268175393-sup-8314@midna.zekjur.net> User-Agent: Sup/git Content-Transfer-Encoding: 8bit Content-Type: multipart/mixed; boundary="=-1268175513-130162-10416-808-1-=" MIME-Version: 1.0 Cc: sup-devel Subject: Re: [sup-devel] [PATCH] Use multiple body arrays when calling before-edit for each reply type X-BeenThere: sup-devel@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Sup developer discussion List-Id: Sup developer discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: sup-devel-bounces@rubyforge.org Errors-To: sup-devel-bounces@rubyforge.org --=-1268175513-130162-10416-808-1-= Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Hi Rich, Excerpts from Rich Lane's message of Sa Feb 27 19:29:27 +0100 2010: > What happens when you edit the message and then select another reply type? You are right, there was a problem here. I reworked the patch, it now behaves like this: As long as you did not edit the message, selecting another reply type changes the body. As soon as you edit one of the bodies, only the headers will be changed if you switch to a different reply type. You find the new version of the patch attached to this mail. Best regards, Michael --=-1268175513-130162-10416-808-1-= Content-Disposition: attachment; filename="0001-Use-multiple-body-arrays-when-calling-before-edit-fo.patch" Content-Type: application/octet-stream; name="0001-Use-multiple-body-arrays-when-calling-before-edit-fo.patch" Content-Transfer-Encoding: base64 RnJvbSBmOTM5NzcwZWJlMWE0NmIzOWQ0ZjE3YzFjNTQ0N2Q3MWY3OWZiOGJm IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNaWNoYWVsIFN0YXBl bGJlcmcgPG1pY2hhZWxAc3RhcGVsYmVyZy5kZT4KRGF0ZTogVHVlLCA5IE1h ciAyMDEwIDIzOjU2OjAyICswMTAwClN1YmplY3Q6IFtQQVRDSF0gVXNlIG11 bHRpcGxlIGJvZHkgYXJyYXlzIHdoZW4gY2FsbGluZyBiZWZvcmUtZWRpdCBm b3IgZWFjaCByZXBseSB0eXBlCgpUaGlzIGFsbG93cyBmb3IgYmVmb3JlLWVk aXQgaG9va3Mgd2hpY2ggbW9kaWZ5IHRoZSBib2R5IG9mIHRoZSBtZXNzYWdl CmJhc2VkIG9uIHRoZSBkaWZmZXJlbnQgaGVhZGVycyAocHJldmlvdXNseSwg dGhleSBjb3VsZCBvbmx5IG1vZGlmeQpoZWFkZXJzKS4KCkFzIGFuIGV4YW1w bGUsIEkgdXNlIGl0IHRvIHNpZ24gbWFpbCBpbiBlbmdsaXNoIGlmIG9uZSBv ZiB0aGUgcmVjaXBpZW50cwoobm90ICp0aGUqIHJlY2lwaWVudCwgYnV0IG9u ZSBvZiB0aGVtKSBpcyBzcGVha2luZyBlbmdsaXNoLgotLS0KIGxpYi9zdXAv bW9kZXMvcmVwbHktbW9kZS5yYiB8ICAgMTcgKysrKysrKysrKysrKysrLS0K IDEgZmlsZXMgY2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS9saWIvc3VwL21vZGVzL3JlcGx5LW1vZGUu cmIgYi9saWIvc3VwL21vZGVzL3JlcGx5LW1vZGUucmIKaW5kZXggM2QzOWE4 YS4uZDZkNmNkMSAxMDA2NDQKLS0tIGEvbGliL3N1cC9tb2Rlcy9yZXBseS1t b2RlLnJiCisrKyBiL2xpYi9zdXAvbW9kZXMvcmVwbHktbW9kZS5yYgpAQCAt NDIsNiArNDIsNyBAQCBFT1MKIAogICBkZWYgaW5pdGlhbGl6ZSBtZXNzYWdl LCB0eXBlX2FyZz1uaWwKICAgICBAbSA9IG1lc3NhZ2UKKyAgICBAZWRpdGVk ID0gZmFsc2UKIAogICAgICMjIGl0J3MgaW1wb3J0YW50IHRvIHB1dCB0aGlz IGVhcmx5IGJlY2F1c2UgaXQgZm9yY2VzIGEgcmVhZCBvZgogICAgICMjIHRo ZSBmdWxsIGhlYWRlcnMgKG1vc3QgaW1wb3J0YW50bHkgdGhlIGxpc3QtcG9z dCBoZWFkZXIsIGlmCkBAIC0xNTAsMTEgKzE1MSwxMyBAQCBFT1MKICAgICAg ICAgOnJlY2lwaWVudAogICAgICAgZW5kKQogCisgICAgQGJvZGllcyA9IHt9 CiAgICAgQGhlYWRlcnMuZWFjaCBkbyB8aywgdnwKLSAgICAgIEhvb2tNYW5h Z2VyLnJ1biAiYmVmb3JlLWVkaXQiLCA6aGVhZGVyID0+IHYsIDpib2R5ID0+ IGJvZHkKKyAgICAgIEBib2RpZXNba10gPSBBcnJheS5uZXcoYm9keSkKKyAg ICAgIEhvb2tNYW5hZ2VyLnJ1biAiYmVmb3JlLWVkaXQiLCA6aGVhZGVyID0+ IHYsIDpib2R5ID0+IEBib2RpZXNba10KICAgICBlbmQKIAotICAgIHN1cGVy IDpoZWFkZXIgPT4gQGhlYWRlcnNbQHR5cGVfc2VsZWN0b3IudmFsXSwgOmJv ZHkgPT4gYm9keSwgOnR3aWRkbGVzID0+IGZhbHNlCisgICAgc3VwZXIgOmhl YWRlciA9PiBAaGVhZGVyc1tAdHlwZV9zZWxlY3Rvci52YWxdLCA6Ym9keSA9 PiBAYm9kaWVzW0B0eXBlX3NlbGVjdG9yLnZhbF0sIDp0d2lkZGxlcyA9PiBm YWxzZQogICAgIGFkZF9zZWxlY3RvciBAdHlwZV9zZWxlY3RvcgogICBlbmQK IApAQCAtMTY0LDYgKzE2Nyw5IEBAIHByb3RlY3RlZAogICAgIHN1cGVyCiAg ICAgaWYgQGhlYWRlcnNbQHR5cGVfc2VsZWN0b3IudmFsXSAhPSBzZWxmLmhl YWRlcgogICAgICAgc2VsZi5oZWFkZXIgPSBAaGVhZGVyc1tAdHlwZV9zZWxl Y3Rvci52YWxdCisgICAgICBpZiAhQGVkaXRlZAorICAgICAgICBzZWxmLmJv ZHkgPSBAYm9kaWVzW0B0eXBlX3NlbGVjdG9yLnZhbF0KKyAgICAgIGVuZAog ICAgICAgdXBkYXRlCiAgICAgZW5kCiAgIGVuZApAQCAtMTcyLDYgKzE3OCw5 IEBAIHByb3RlY3RlZAogICAgIHN1cGVyCiAgICAgaWYgQGhlYWRlcnNbQHR5 cGVfc2VsZWN0b3IudmFsXSAhPSBzZWxmLmhlYWRlcgogICAgICAgc2VsZi5o ZWFkZXIgPSBAaGVhZGVyc1tAdHlwZV9zZWxlY3Rvci52YWxdCisgICAgICBp ZiAhQGVkaXRlZAorICAgICAgICBzZWxmLmJvZHkgPSBAYm9kaWVzW0B0eXBl X3NlbGVjdG9yLnZhbF0KKyAgICAgIGVuZAogICAgICAgdXBkYXRlCiAgICAg ZW5kCiAgIGVuZApAQCAtMTg4LDYgKzE5NywxMCBAQCBwcm90ZWN0ZWQKICAg ZW5kCiAKICAgZGVmIGhhbmRsZV9uZXdfdGV4dCBuZXdfaGVhZGVyLCBuZXdf Ym9keQorICAgIGlmIG5ld19ib2R5ICE9IEBib2RpZXNbQHR5cGVfc2VsZWN0 b3IudmFsXQorICAgICAgQGJvZGllc1tAdHlwZV9zZWxlY3Rvci52YWxdID0g bmV3X2JvZHkKKyAgICAgIEBlZGl0ZWQgPSB0cnVlCisgICAgZW5kCiAgICAg b2xkX2hlYWRlciA9IEBoZWFkZXJzW0B0eXBlX3NlbGVjdG9yLnZhbF0KICAg ICBpZiBuZXdfaGVhZGVyLnNpemUgIT0gb2xkX2hlYWRlci5zaXplIHx8IG9s ZF9oZWFkZXIuYW55PyB7IHxrLCB2fCBuZXdfaGVhZGVyW2tdICE9IHYgfQog ICAgICAgQHR5cGVfc2VsZWN0b3Iuc2V0X3RvIDp1c2VyCi0tIAoxLjYuNQoK --=-1268175513-130162-10416-808-1-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel --=-1268175513-130162-10416-808-1-=--