From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.86.59.13 with SMTP id h13cs307616fga; Sat, 27 Feb 2010 10:12:28 -0800 (PST) Received: by 10.224.59.71 with SMTP id k7mr1150555qah.245.1267294347497; Sat, 27 Feb 2010 10:12:27 -0800 (PST) Return-Path: Received: from rubyforge.org (rubyforge.org [205.234.109.19]) by mx.google.com with ESMTP id 7si3479916qwf.37.2010.02.27.10.12.27; Sat, 27 Feb 2010 10:12:27 -0800 (PST) Received-SPF: pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19; Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-devel-bounces@rubyforge.org Received: from rubyforge.org (rubyforge.org [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id D421E18582F7; Sat, 27 Feb 2010 13:12:26 -0500 (EST) Received: from pion.club.cc.cmu.edu (PION.CLUB.CC.cmu.edu [128.237.157.88]) by rubyforge.org (Postfix) with ESMTP id 9900A18582DC for ; Sat, 27 Feb 2010 13:12:20 -0500 (EST) Received: from rlane by pion.club.cc.cmu.edu with local (Exim 4.69) (envelope-from ) id 1NlR9H-0006cx-VR; Sat, 27 Feb 2010 13:12:19 -0500 From: Rich Lane To: Michael Stapelberg In-reply-to: <1267274808-sup-1569@midna.zekjur.net> References: <1266549876-sup-2041@midna.zekjur.net> <1267258772-sup-9178@zyrg.net> <1267274808-sup-1569@midna.zekjur.net> Date: Sat, 27 Feb 2010 13:12:19 -0500 Message-Id: <1267293975-sup-6753@zyrg.net> User-Agent: Sup/git Cc: sup-devel Subject: Re: [sup-devel] [PATCH] Bugfix: Don\xe2\x80\x99t call Ncurses.getch when in shell\x96out mode X-BeenThere: sup-devel@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Sup developer discussion List-Id: Sup developer discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: sup-devel-bounces@rubyforge.org Errors-To: sup-devel-bounces@rubyforge.org Excerpts from Michael Stapelberg's message of 2010-02-27 07:48:39 -0500: > Hi Rich, > > Excerpts from Rich Lane's message of Sa Feb 27 09:23:39 +0100 2010: > > What's the reason for passing the BufferManager singleton as an > > argument? > I am passing the BufferManager because I could not figure out how to access > it from inside the Ncurses module. Maybe there is a better way, if so, please > tell me :-). The reason we use these ugly singleton *Manager objects is to avoid exactly this kind of plumbing. Since Ncurses is outside the Redwood namespace you'll need to refer to it as Redwood::BufferManager. > > What does "drop the input" mean? > It means returning nil instead of Ncurses.getch, so maybe a better way of > saying it is "We do not check for input because it would restart Ncurses > while in shell-out mode". Ok, that's how I read the code. When I saw "drop" in the comment I thought it was going to read input and throw it away. _______________________________________________ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel