From: Rich Lane <rlane@club.cc.cmu.edu>
To: Michael Stapelberg <michael+sup@stapelberg.de>
Cc: sup-devel <sup-devel@rubyforge.org>
Subject: Re: [sup-devel] [PATCH] Bugfix: Don\xe2\x80\x99t call Ncurses.getch when in shell\x96out mode
Date: Sat, 27 Feb 2010 13:12:19 -0500 [thread overview]
Message-ID: <1267293975-sup-6753@zyrg.net> (raw)
In-Reply-To: <1267274808-sup-1569@midna.zekjur.net>
Excerpts from Michael Stapelberg's message of 2010-02-27 07:48:39 -0500:
> Hi Rich,
>
> Excerpts from Rich Lane's message of Sa Feb 27 09:23:39 +0100 2010:
> > What's the reason for passing the BufferManager singleton as an
> > argument?
> I am passing the BufferManager because I could not figure out how to access
> it from inside the Ncurses module. Maybe there is a better way, if so, please
> tell me :-).
The reason we use these ugly singleton *Manager objects is to avoid
exactly this kind of plumbing. Since Ncurses is outside the Redwood
namespace you'll need to refer to it as Redwood::BufferManager.
> > What does "drop the input" mean?
> It means returning nil instead of Ncurses.getch, so maybe a better way of
> saying it is "We do not check for input because it would restart Ncurses
> while in shell-out mode".
Ok, that's how I read the code. When I saw "drop" in the comment I
thought it was going to read input and throw it away.
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
next prev parent reply other threads:[~2010-02-27 18:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-19 3:26 [sup-devel] [PATCH] Bugfix: Don’t call Ncurses.getch when in shell�out mode Michael Stapelberg
2010-02-27 8:23 ` [sup-devel] [PATCH] Bugfix: Don\xe2\x80\x99t call Ncurses.getch when in shell\x96out mode Rich Lane
2010-02-27 12:48 ` Michael Stapelberg
2010-02-27 18:12 ` Rich Lane [this message]
2010-02-27 19:00 ` [sup-devel] [PATCH] Bugfix: Don't call Ncurses.getch when in shell-out mode William Morgan
2010-02-27 19:03 ` Rich Lane
2010-02-27 19:29 ` William Morgan
2010-02-27 19:27 ` [sup-devel] [PATCH] Bugfix: Don\xe2\x80\x99t call Ncurses.getch when in shell\x96out mode Michael Stapelberg
2010-02-27 20:14 ` Rich Lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1267293975-sup-6753@zyrg.net \
--to=rlane@club.cc.cmu.edu \
--cc=michael+sup@stapelberg.de \
--cc=sup-devel@rubyforge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox