From mboxrd@z Thu Jan  1 00:00:00 1970
Received: by 10.86.59.13 with SMTP id h13cs307473fga;
        Sat, 27 Feb 2010 10:06:47 -0800 (PST)
Received: by 10.224.94.73 with SMTP id y9mr1169852qam.90.1267294006559;
        Sat, 27 Feb 2010 10:06:46 -0800 (PST)
Return-Path: <sup-devel-bounces@rubyforge.org>
Received: from rubyforge.org (rubyforge.org [205.234.109.19])
        by mx.google.com with ESMTP id 8si4287010qwj.45.2010.02.27.10.06.46;
        Sat, 27 Feb 2010 10:06:46 -0800 (PST)
Received-SPF: pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19;
Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-devel-bounces@rubyforge.org
Received: from rubyforge.org (rubyforge.org [127.0.0.1])
	by rubyforge.org (Postfix) with ESMTP id 04FF518582F8;
	Sat, 27 Feb 2010 13:06:46 -0500 (EST)
Received: from pion.club.cc.cmu.edu (PION.CLUB.CC.cmu.edu [128.237.157.88])
	by rubyforge.org (Postfix) with ESMTP id 5B60718582BF
	for <sup-devel@rubyforge.org>; Sat, 27 Feb 2010 13:05:59 -0500 (EST)
Received: from rlane by pion.club.cc.cmu.edu with local (Exim 4.69)
	(envelope-from <rlane@zyrg.net>)
	id 1NlR38-0006cI-QE; Sat, 27 Feb 2010 13:05:58 -0500
From: Rich Lane <rlane@club.cc.cmu.edu>
To: Michael Stapelberg <michael+sup@stapelberg.de>
In-reply-to: <1267276103-sup-6406@midna.zekjur.net>
References: <1266493070-sup-7733@midna.zekjur.net>
	<1267219197-sup-2428@zyrg.net>
	<1267276103-sup-6406@midna.zekjur.net>
Date: Sat, 27 Feb 2010 13:05:58 -0500
Message-Id: <1267293663-sup-2241@zyrg.net>
User-Agent: Sup/git
Cc: sup-devel <sup-devel@rubyforge.org>
Subject: Re: [sup-devel] [PATCH] Implement inline GPG
X-BeenThere: sup-devel@rubyforge.org
X-Mailman-Version: 2.1.12
Precedence: list
Reply-To: Sup developer discussion <sup-devel@rubyforge.org>
List-Id: Sup developer discussion <sup-devel.rubyforge.org>
List-Unsubscribe: <http://rubyforge.org/mailman/options/sup-devel>,
	<mailto:sup-devel-request@rubyforge.org?subject=unsubscribe>
List-Archive: <http://rubyforge.org/pipermail/sup-devel>
List-Post: <mailto:sup-devel@rubyforge.org>
List-Help: <mailto:sup-devel-request@rubyforge.org?subject=help>
List-Subscribe: <http://rubyforge.org/mailman/listinfo/sup-devel>,
	<mailto:sup-devel-request@rubyforge.org?subject=subscribe>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: sup-devel-bounces@rubyforge.org
Errors-To: sup-devel-bounces@rubyforge.org

Excerpts from Michael Stapelberg's message of 2010-02-27 08:11:28 -0500:
> But I guess that no client would put any data before/after these lines,
> so adding ^ and $ to the regex in 530 seems right.

The problem is sign_start will be nil if the text isn't on a line by
itself, causing a crash a few lines later. This happened to me when I
was running with this patch on my edge branch. I'd remove the
duplication by making the condition of the if the sign_start assignment.
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel