From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.86.59.13 with SMTP id h13cs300530fga; Sat, 27 Feb 2010 05:13:20 -0800 (PST) Received: by 10.224.4.201 with SMTP id 9mr1012937qas.77.1267276399301; Sat, 27 Feb 2010 05:13:19 -0800 (PST) Return-Path: Received: from rubyforge.org (rubyforge.org [205.234.109.19]) by mx.google.com with ESMTP id 5si3820268qwg.13.2010.02.27.05.13.18; Sat, 27 Feb 2010 05:13:19 -0800 (PST) Received-SPF: pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19; Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-devel-bounces@rubyforge.org Received: from rubyforge.org (rubyforge.org [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id C5C5318582FF; Sat, 27 Feb 2010 08:13:18 -0500 (EST) Received: from twice-irc.de (mx2.twice-irc.de [79.140.35.195]) by rubyforge.org (Postfix) with ESMTP id 9D15018582F7 for ; Sat, 27 Feb 2010 08:12:32 -0500 (EST) Received: from midna.zekjur.net (midna.zekjur.net [IPv6:2001:4d88:1008:4242:21c:c0ff:fe7e:4776]) by twice-irc.de (Postfix) with ESMTPSA id D2F62166640; Sat, 27 Feb 2010 14:11:28 +0100 (CET) Received: by midna.zekjur.net (Postfix, from userid 101) id 380C532083; Sat, 27 Feb 2010 14:11:28 +0100 (CET) From: Michael Stapelberg To: Rich Lane In-reply-to: <1267219197-sup-2428@zyrg.net> References: <1266493070-sup-7733@midna.zekjur.net> <1267219197-sup-2428@zyrg.net> Date: Sat, 27 Feb 2010 14:11:28 +0100 Message-Id: <1267276103-sup-6406@midna.zekjur.net> User-Agent: Sup/git Cc: sup-devel Subject: Re: [sup-devel] [PATCH] Implement inline GPG X-BeenThere: sup-devel@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Sup developer discussion List-Id: Sup developer discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: sup-devel-bounces@rubyforge.org Errors-To: sup-devel-bounces@rubyforge.org Hi Rich, Excerpts from Rich Lane's message of Fr Feb 26 22:24:08 +0100 2010: > message.rb:531 assumes the text will be on its own line, while the > regex on 530 does not. (check my edge branch for line numbers) Right. RFC 2440 is not really clear about that. In 6.2 it only says: "An Armor Header Line consists of the appropriate header line text surrounded by five (5) dashes ('-', 0x2D) on either side of the header line text." But I guess that no client would put any data before/after these lines, so adding ^ and $ to the regex in 530 seems right. Let me know if you need any help validating this patch. Best regards, Michael _______________________________________________ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel