From: Michael Stapelberg <michael+sup@stapelberg.de>
To: Rich Lane <rlane@club.cc.cmu.edu>
Cc: sup-devel <sup-devel@rubyforge.org>
Subject: Re: [sup-devel] [PATCH] Implement inline GPG
Date: Sat, 27 Feb 2010 14:11:28 +0100 [thread overview]
Message-ID: <1267276103-sup-6406@midna.zekjur.net> (raw)
In-Reply-To: <1267219197-sup-2428@zyrg.net>
Hi Rich,
Excerpts from Rich Lane's message of Fr Feb 26 22:24:08 +0100 2010:
> message.rb:531 assumes the text will be on its own line, while the
> regex on 530 does not. (check my edge branch for line numbers)
Right. RFC 2440 is not really clear about that. In 6.2 it only says:
"An Armor Header Line consists of the appropriate header line text
surrounded by five (5) dashes ('-', 0x2D) on either side of the
header line text."
But I guess that no client would put any data before/after these lines,
so adding ^ and $ to the regex in 530 seems right.
Let me know if you need any help validating this patch.
Best regards,
Michael
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
next prev parent reply other threads:[~2010-02-27 13:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-18 11:40 Michael Stapelberg
2010-02-26 21:24 ` Rich Lane
2010-02-27 13:11 ` Michael Stapelberg [this message]
2010-02-27 18:05 ` Rich Lane
2010-03-01 13:45 ` Michael Stapelberg
2010-03-01 14:36 ` Christian Dietrich
2010-03-01 16:49 ` Michael Stapelberg
2010-03-01 17:46 ` Christian Dietrich
2010-03-09 16:43 ` [sup-devel] [PATCH] Implement inline GPG (updated) Michael Stapelberg
2010-03-10 21:23 ` Michael Stapelberg
2010-03-12 4:43 ` Rich Lane
2010-03-12 11:02 ` Michael Stapelberg
2010-03-15 5:19 ` Rich Lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1267276103-sup-6406@midna.zekjur.net \
--to=michael+sup@stapelberg.de \
--cc=rlane@club.cc.cmu.edu \
--cc=sup-devel@rubyforge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox