From mboxrd@z Thu Jan  1 00:00:00 1970
Received: by 10.86.59.13 with SMTP id h13cs278574fga;
        Fri, 26 Feb 2010 13:25:14 -0800 (PST)
Received: by 10.224.63.214 with SMTP id c22mr609394qai.22.1267219514078;
        Fri, 26 Feb 2010 13:25:14 -0800 (PST)
Return-Path: <sup-devel-bounces@rubyforge.org>
Received: from rubyforge.org (rubyforge.org [205.234.109.19])
        by mx.google.com with ESMTP id 4si85649qwe.36.2010.02.26.13.25.13;
        Fri, 26 Feb 2010 13:25:14 -0800 (PST)
Received-SPF: pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19;
Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-devel-bounces@rubyforge.org
Received: from rubyforge.org (rubyforge.org [127.0.0.1])
	by rubyforge.org (Postfix) with ESMTP id 674A11858300;
	Fri, 26 Feb 2010 16:25:13 -0500 (EST)
Received: from pion.club.cc.cmu.edu (PION.CLUB.CC.cmu.edu [128.237.157.88])
	by rubyforge.org (Postfix) with ESMTP id 45D5218582D2
	for <sup-devel@rubyforge.org>; Fri, 26 Feb 2010 16:24:09 -0500 (EST)
Received: from rlane by pion.club.cc.cmu.edu with local (Exim 4.69)
	(envelope-from <rlane@zyrg.net>)
	id 1Nl7fM-0005YQ-2u; Fri, 26 Feb 2010 16:24:08 -0500
From: Rich Lane <rlane@club.cc.cmu.edu>
To: Michael Stapelberg <michael+sup@stapelberg.de>
In-reply-to: <1266493070-sup-7733@midna.zekjur.net>
References: <1266493070-sup-7733@midna.zekjur.net>
Date: Fri, 26 Feb 2010 16:24:08 -0500
Message-Id: <1267219197-sup-2428@zyrg.net>
User-Agent: Sup/git
Cc: sup-devel <sup-devel@rubyforge.org>
Subject: Re: [sup-devel] [PATCH] Implement inline GPG
X-BeenThere: sup-devel@rubyforge.org
X-Mailman-Version: 2.1.12
Precedence: list
Reply-To: Sup developer discussion <sup-devel@rubyforge.org>
List-Id: Sup developer discussion <sup-devel.rubyforge.org>
List-Unsubscribe: <http://rubyforge.org/mailman/options/sup-devel>,
	<mailto:sup-devel-request@rubyforge.org?subject=unsubscribe>
List-Archive: <http://rubyforge.org/pipermail/sup-devel>
List-Post: <mailto:sup-devel@rubyforge.org>
List-Help: <mailto:sup-devel-request@rubyforge.org?subject=help>
List-Subscribe: <http://rubyforge.org/mailman/listinfo/sup-devel>,
	<mailto:sup-devel-request@rubyforge.org?subject=subscribe>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: sup-devel-bounces@rubyforge.org
Errors-To: sup-devel-bounces@rubyforge.org

Excerpts from Michael Stapelberg's message of 2010-02-18 06:40:45 -0500:
> Hi,
> 
> as my previous patch was not merged, I have updated the patch to apply against
> the current code. Furthermore, it now correctly handles character sets for the
> GPG encrypted part.
> 
> The patch has been tested by me and another user and seems to work fine.
> 
> Please merge it for the next release.
> 
> Best regards,
> Michael

Not a full review yet, just a bug that bit me:

message.rb:531 assumes the text will be on its own line, while the
regex on 530 does not. (check my edge branch for line numbers)
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel