From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.86.59.13 with SMTP id h13cs128185fga; Mon, 15 Feb 2010 10:31:36 -0800 (PST) Received: by 10.224.44.229 with SMTP id b37mr160783qaf.367.1266258680680; Mon, 15 Feb 2010 10:31:20 -0800 (PST) Return-Path: Received: from rubyforge.org (rubyforge.org [205.234.109.19]) by mx.google.com with ESMTP id 7si387271qwf.44.2010.02.15.10.31.20; Mon, 15 Feb 2010 10:31:20 -0800 (PST) Received-SPF: pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19; Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-devel-bounces@rubyforge.org Received: from rubyforge.org (rubyforge.org [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id D4C3F18582E7; Mon, 15 Feb 2010 13:31:19 -0500 (EST) Received: from twice-irc.de (mx2.twice-irc.de [79.140.35.195]) by rubyforge.org (Postfix) with ESMTP id 56B1F18582E1 for ; Mon, 15 Feb 2010 13:31:01 -0500 (EST) Received: from midna.zekjur.net (midna.zekjur.net [IPv6:2001:4d88:1008:4242:21c:c0ff:fe7e:4776]) by twice-irc.de (Postfix) with ESMTPSA id EBC14166637 for ; Mon, 15 Feb 2010 19:30:59 +0100 (CET) Received: by midna.zekjur.net (Postfix, from userid 101) id 47F2997A01F; Mon, 15 Feb 2010 19:30:59 +0100 (CET) From: Michael Stapelberg To: sup-devel Date: Mon, 15 Feb 2010 19:30:59 +0100 Message-Id: <1266258536-sup-3345@midna.zekjur.net> User-Agent: Sup/git Content-Transfer-Encoding: 8bit Content-Type: multipart/mixed; boundary="=-1266258659-245356-27773-2212-2-=" MIME-Version: 1.0 Subject: [sup-devel] [PATCH] catch xapian query parser exceptions and display them to the user X-BeenThere: sup-devel@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Sup developer discussion List-Id: Sup developer discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: sup-devel-bounces@rubyforge.org Errors-To: sup-devel-bounces@rubyforge.org --=-1266258659-245356-27773-2212-2-= Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Hi, a query such as "NOT label:debian" will generate an error in the xapian query parser. Instead of crashing, the user should see the error message to get his query right. The attached patch fixes this. Please note that the appropriate type instead of RuntimeError would be Xapian::QueryParserError, but the latter is not defined for some reason. A problem with the xapian ruby bindings? Best regards, Michael --=-1266258659-245356-27773-2212-2-= Content-Disposition: attachment; filename="0001-xapian.patch" Content-Type: application/octet-stream; name="0001-xapian.patch" Content-Transfer-Encoding: base64 RnJvbSA2M2U2MWQwYjAyNmM1ZGE4NzVhNzcxZThmYjBlNmU4ZmY4ZDhkYWUz IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNaWNoYWVsIFN0YXBl bGJlcmcgPG1pY2hhZWxAc3RhcGVsYmVyZy5kZT4KRGF0ZTogTW9uLCAxNSBG ZWIgMjAxMCAxOToyNzozOCArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIGNhdGNo IHhhcGlhbiBxdWVyeSBwYXJzZXIgZXhjZXB0aW9ucyBhbmQgZGlzcGxheSB0 aGVtIHRvIHRoZSB1c2VyCgotLS0KIGxpYi9zdXAveGFwaWFuX2luZGV4LnJi IHwgICAgNiArKysrKy0KIDEgZmlsZXMgY2hhbmdlZCwgNSBpbnNlcnRpb25z KCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpYi9zdXAveGFw aWFuX2luZGV4LnJiIGIvbGliL3N1cC94YXBpYW5faW5kZXgucmIKaW5kZXgg Y2Y3MDFiNC4uYzNkNDkyYiAxMDA2NDQKLS0tIGEvbGliL3N1cC94YXBpYW5f aW5kZXgucmIKKysrIGIvbGliL3N1cC94YXBpYW5faW5kZXgucmIKQEAgLTI2 NSw3ICsyNjUsMTEgQEAgRU9TCiAgICAgcXAuYWRkX3ZhbHVlcmFuZ2Vwcm9j ZXNzb3IoWGFwaWFuOjpOdW1iZXJWYWx1ZVJhbmdlUHJvY2Vzc29yLm5ldyhE QVRFX1ZBTFVFTk8sICdkYXRlOicsIHRydWUpKQogICAgIE5PUk1BTF9QUkVG SVguZWFjaCB7IHxrLHZ8IHFwLmFkZF9wcmVmaXggaywgdiB9CiAgICAgQk9P TEVBTl9QUkVGSVguZWFjaCB7IHxrLHZ8IHFwLmFkZF9ib29sZWFuX3ByZWZp eCBrLCB2IH0KLSAgICB4YXBpYW5fcXVlcnkgPSBxcC5wYXJzZV9xdWVyeShz dWJzLCBYYXBpYW46OlF1ZXJ5UGFyc2VyOjpGTEFHX1BIUkFTRXxYYXBpYW46 OlF1ZXJ5UGFyc2VyOjpGTEFHX0JPT0xFQU58WGFwaWFuOjpRdWVyeVBhcnNl cjo6RkxBR19MT1ZFSEFURXxYYXBpYW46OlF1ZXJ5UGFyc2VyOjpGTEFHX1dJ TERDQVJELCBQUkVGSVhbJ2JvZHknXSkKKyAgICBiZWdpbgorICAgICAgeGFw aWFuX3F1ZXJ5ID0gcXAucGFyc2VfcXVlcnkoc3VicywgWGFwaWFuOjpRdWVy eVBhcnNlcjo6RkxBR19QSFJBU0V8WGFwaWFuOjpRdWVyeVBhcnNlcjo6RkxB R19CT09MRUFOfFhhcGlhbjo6UXVlcnlQYXJzZXI6OkZMQUdfTE9WRUhBVEV8 WGFwaWFuOjpRdWVyeVBhcnNlcjo6RkxBR19XSUxEQ0FSRCwgUFJFRklYWydi b2R5J10pCisgICAgcmVzY3VlIFJ1bnRpbWVFcnJvciA9PiBlCisgICAgICBy YWlzZSBQYXJzZUVycm9yLCAieGFwaWFuIHF1ZXJ5IHBhcnNlciBlcnJvcjog I3tlfSIKKyAgICBlbmQKIAogICAgIGRlYnVnICJwYXJzZWQgeGFwaWFuIHF1 ZXJ5OiAje3hhcGlhbl9xdWVyeS5kZXNjcmlwdGlvbn0iCiAKLS0gCjEuNi41 Cgo= --=-1266258659-245356-27773-2212-2-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel --=-1266258659-245356-27773-2212-2-=--