[sup-devel] [issue58] Set background for starred column

* [sup-devel] [issue58] Set background for starred column
@ 2010-01-29 10:14 Gregor Hoffleit
  0 siblings, 0 replies; only message in thread
From: Gregor Hoffleit @ 2010-01-29 10:14 UTC (permalink / raw)
  To: sup-devel

[-- Attachment #1: Type: text/plain, Size: 803 bytes --]


New submission from Gregor Hoffleit <gregor@hoffleit.de>:

For the sake of consistency, Sup should always use the starred_color for the 
'starred' column in the thread-index-mode, whether there's a star or a blank.

Rationale: With this patch, I'm able to set the background color of the thread-
index to bg:7 without having to change my term's background color. Without the 
patch, the background color shines through in the starred column.

----------
files: bg-starred.diff
messages: 143
nosy: flight
priority: bug
ruby_version: 1.8.5
status: unread
sup_version: 0.10.2
title: Set background for starred column

_________________________________________
Sup issue tracker <sup-bugs@masanjin.net>
<http://masanjin.net/sup-bugs/issue58>
_________________________________________

[-- Attachment #2: bg-starred.diff --]
[-- Type: application/octet-stream, Size: 483 bytes --]

diff --git a/lib/sup/modes/thread-index-mode.rb b/lib/sup/modes/thread-index-mode.rb
index 7ae03cc..dc132a5 100644
--- a/lib/sup/modes/thread-index-mode.rb
+++ b/lib/sup/modes/thread-index-mode.rb
@@ -847,7 +847,7 @@ protected
     [ 
       [:tagged_color, @tags.tagged?(t) ? ">" : " "],
       [:date_color, sprintf("%#{@date_width}s", date)],
-      (starred ? [:starred_color, "*"] : [:none, " "]),
+      [:starred_color, (starred ? "*" : " ")],
     ] +
       from +
       [

[-- Attachment #3: Type: text/plain, Size: 143 bytes --]

_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel

^ permalink raw reply	[flat|nested] only message in thread