From: Gregor Hoffleit <sup-bugs@masanjin.net>
To: sup-devel@rubyforge.org
Subject: [sup-devel] [issue58] Set background for starred column
Date: Fri, 29 Jan 2010 10:14:40 +0000 [thread overview]
Message-ID: <1264760080.41.0.139357784083.issue58@masanjin.net> (raw)
In-Reply-To: <1264760080.41.0.139357784083.issue58@masanjin.net>
[-- Attachment #1: Type: text/plain, Size: 803 bytes --]
New submission from Gregor Hoffleit <gregor@hoffleit.de>:
For the sake of consistency, Sup should always use the starred_color for the
'starred' column in the thread-index-mode, whether there's a star or a blank.
Rationale: With this patch, I'm able to set the background color of the thread-
index to bg:7 without having to change my term's background color. Without the
patch, the background color shines through in the starred column.
----------
files: bg-starred.diff
messages: 143
nosy: flight
priority: bug
ruby_version: 1.8.5
status: unread
sup_version: 0.10.2
title: Set background for starred column
_________________________________________
Sup issue tracker <sup-bugs@masanjin.net>
<http://masanjin.net/sup-bugs/issue58>
_________________________________________
[-- Attachment #2: bg-starred.diff --]
[-- Type: application/octet-stream, Size: 483 bytes --]
diff --git a/lib/sup/modes/thread-index-mode.rb b/lib/sup/modes/thread-index-mode.rb
index 7ae03cc..dc132a5 100644
--- a/lib/sup/modes/thread-index-mode.rb
+++ b/lib/sup/modes/thread-index-mode.rb
@@ -847,7 +847,7 @@ protected
[
[:tagged_color, @tags.tagged?(t) ? ">" : " "],
[:date_color, sprintf("%#{@date_width}s", date)],
- (starred ? [:starred_color, "*"] : [:none, " "]),
+ [:starred_color, (starred ? "*" : " ")],
] +
from +
[
[-- Attachment #3: Type: text/plain, Size: 143 bytes --]
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
parent reply other threads:[~2010-01-29 10:14 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1264760080.41.0.139357784083.issue58@masanjin.net>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264760080.41.0.139357784083.issue58@masanjin.net \
--to=sup-bugs@masanjin.net \
--cc=sup-devel@rubyforge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox