Re: [sup-devel] [issue53] Error if the composed text has tabs in the first character

From: Tero Tilus <tero@tilus.net>
To: Anirudh Sanjeev <sup-bugs@masanjin.net>
Cc: sup-devel <sup-devel@rubyforge.org>
Subject: Re: [sup-devel] [issue53] Error if the composed text has tabs in the first character
Date: Thu, 28 Jan 2010 00:15:19 +0200	[thread overview]
Message-ID: <1264630303-sup-9772@tilus.net> (raw)
In-Reply-To: <1264626708.47.0.495243760209.issue53@masanjin.net>

[-- Attachment #1: Type: text/plain, Size: 377 bytes --]

Anirudh Sanjeev, 2010-01-27 23:11:
> Steps to reproduce:
> 1. Compose message with a tab as a first character
> 2. View composed message in the compose-mode

Looks like tabs are counted as 1 (instead of 8) when calculating
string display width.  Dunno why this did not affect thread-view-mode
thought.  Patch attached.

-- 
Tero Tilus ## 050 3635 235 ## http://tero.tilus.net/

[-- Attachment #2: 0001-Count-tabs-as-8-chars-when-calculating-display-lengt.patch --]
[-- Type: application/octet-stream, Size: 620 bytes --]

From 2a0209b9dbd246e1791b08f0906f27327a1d5f39 Mon Sep 17 00:00:00 2001
From: Tero Tilus <tero@tilus.net>
Date: Thu, 28 Jan 2010 00:05:25 +0200
Subject: [PATCH] Count tabs as 8 chars when calculating display length

Signed-off-by: Tero Tilus <tero@tilus.net>
---
 lib/sup/util.rb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/sup/util.rb b/lib/sup/util.rb
index 861db7f..6757973 100644
--- a/lib/sup/util.rb
+++ b/lib/sup/util.rb
@@ -181,7 +181,7 @@ class String
       scan(/./u).size
     else
       size
-    end
+    end + 7 * (count "\t")
   end
 
   def camel_to_hyphy
-- 
1.5.6.5


[-- Attachment #3: Type: text/plain, Size: 143 bytes --]

_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
