Archive of RubyForge sup-devel mailing list
 help / color / mirror / Atom feed
* [sup-devel] [PATCH] fix missing parentheses warning
       [not found] <8b854d6b1001250307o42e85f44id88d3eea7f18beb4@mail.gmail.com>
@ 2010-01-25 21:52 ` Rich Lane
  2010-01-26 13:20   ` William Morgan
  0 siblings, 1 reply; 2+ messages in thread
From: Rich Lane @ 2010-01-25 21:52 UTC (permalink / raw)
  To: sup-devel

---
 lib/sup/message.rb |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/sup/message.rb b/lib/sup/message.rb
index 3e55de5..a85cc0d 100644
--- a/lib/sup/message.rb
+++ b/lib/sup/message.rb
@@ -450,9 +450,9 @@ private
         subj = decode_header_field(payload.header.subject) || DEFAULT_SUBJECT
         subj = Message.normalize_subj(subj.gsub(/\s+/, " ").gsub(/\s+$/, ""))
         msgdate = payload.header.date
-        from_person = from ? Person.from_address(decode_header_field from) : nil
-        to_people = to ? Person.from_address_list(decode_header_field to) : nil
-        cc_people = cc ? Person.from_address_list(decode_header_field cc) : nil
+        from_person = from ? Person.from_address(decode_header_field(from)) : nil
+        to_people = to ? Person.from_address_list(decode_header_field(to)) : nil
+        cc_people = cc ? Person.from_address_list(decode_header_field(cc)) : nil
         [Chunk::EnclosedMessage.new(from_person, to_people, cc_people, msgdate, subj)] + message_to_chunks(payload, encrypted)
       else
         debug "no body for message/rfc822 enclosure; skipping"
-- 
1.5.6.5

_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [sup-devel] [PATCH] fix missing parentheses warning
  2010-01-25 21:52 ` [sup-devel] [PATCH] fix missing parentheses warning Rich Lane
@ 2010-01-26 13:20   ` William Morgan
  0 siblings, 0 replies; 2+ messages in thread
From: William Morgan @ 2010-01-26 13:20 UTC (permalink / raw)
  To: sup-devel

Applied directly to master. Thanks!

What do people think of turning warnings off entirely for bin/sup?
Should just be a matter of setting $VERBOSE = nil. It is a curses app,
after all.
-- 
William <wmorgan-sup@masanjin.net>
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-01-26 13:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <8b854d6b1001250307o42e85f44id88d3eea7f18beb4@mail.gmail.com>
2010-01-25 21:52 ` [sup-devel] [PATCH] fix missing parentheses warning Rich Lane
2010-01-26 13:20   ` William Morgan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox