From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.213.28.69 with SMTP id l5cs16719ebc; Sat, 23 Jan 2010 05:12:46 -0800 (PST) Received: by 10.224.13.145 with SMTP id c17mr2671950qaa.244.1264252365623; Sat, 23 Jan 2010 05:12:45 -0800 (PST) Return-Path: Received: from rubyforge.org (rubyforge.org [205.234.109.19]) by mx.google.com with ESMTP id 4si10986483qwe.25.2010.01.23.05.12.45; Sat, 23 Jan 2010 05:12:45 -0800 (PST) Received-SPF: pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19; Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-devel-bounces@rubyforge.org Received: from rubyforge.org (rubyforge.org [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id B44D81858302; Sat, 23 Jan 2010 08:12:43 -0500 (EST) Received: from entry.masanjin.net (masanjin.net [209.20.72.13]) by rubyforge.org (Postfix) with ESMTP id C47911858306 for ; Sat, 23 Jan 2010 08:12:27 -0500 (EST) Received: from w by entry.masanjin.net with local (Exim 4.69) (envelope-from ) id 1NYfm2-0005JF-Nn for sup-devel@rubyforge.org; Sat, 23 Jan 2010 08:11:34 -0500 From: William Morgan To: sup-devel In-reply-to: <1264117436-sup-4429@tilus.net> References: <1263574849-sup-3477@sam.mediasupervision.de> <1263680819-sup-415@tilus.net> <1264117436-sup-4429@tilus.net> Date: Sat, 23 Jan 2010 08:11:33 -0500 Message-Id: <1264252198-sup-6507@masanjin.net> User-Agent: Sup/git Subject: Re: [sup-devel] [PATCH] Message#edit_labels [was: Ruby question: before-add-message.rb and adding multiple labels at once] X-BeenThere: sup-devel@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Sup developer discussion List-Id: Sup developer discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: sup-devel-bounces@rubyforge.org Errors-To: sup-devel-bounces@rubyforge.org Reformatted excerpts from Tero Tilus's message of 2010-01-21: > Did this get merged? I got no feedback. Sorry about that. This is very similar to the code in ThreadViewMode#multi_edit_labels, so I would prefer a solution that shared a codepath. It's also important to call LabelManager.<< for each label, to make sure they appear in label-list-mode. -- William _______________________________________________ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel