From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.213.28.69 with SMTP id l5cs493818ebc; Wed, 20 Jan 2010 06:34:49 -0800 (PST) Received: by 10.229.31.206 with SMTP id z14mr24139qcc.79.1263998088896; Wed, 20 Jan 2010 06:34:48 -0800 (PST) Return-Path: Received: from rubyforge.org (rubyforge.org [205.234.109.19]) by mx.google.com with ESMTP id 7si18151668qwf.34.2010.01.20.06.34.48; Wed, 20 Jan 2010 06:34:48 -0800 (PST) Received-SPF: pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19; Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-devel-bounces@rubyforge.org; dkim=neutral (body hash did not verify) header.i=@gmail.com Received: from rubyforge.org (rubyforge.org [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id 5381C1858317; Wed, 20 Jan 2010 09:34:48 -0500 (EST) Received: from mail-pw0-f60.google.com (mail-pw0-f60.google.com [209.85.160.60]) by rubyforge.org (Postfix) with ESMTP id CE2BA1858306 for ; Wed, 20 Jan 2010 09:33:02 -0500 (EST) Received: by pwj17 with SMTP id 17so1750475pwj.19 for ; Wed, 20 Jan 2010 06:32:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:content-type:cc:subject:from :to:in-reply-to:references:date:message-id:user-agent :content-transfer-encoding; bh=+QFMhRczRF+A3VQjGlB70HQk/8R6yEtb7YMugOxU63U=; b=d9DmnKqBnD+JxUOIOhgsK8NY3KpLvKEu36J1Nk3IwnylCmMkrEUABMf9hJLGqpfbgB t8eLEFgIHHfK+rWFK+lqAfIwUV+YS+ZUOc53YR3CwCjvWdFO+RqRztYDmuxMhnCsvENU zK0CkF6k1pvvWYtepDnbXTC8B826sdJClqHME= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=content-type:cc:subject:from:to:in-reply-to:references:date :message-id:user-agent:content-transfer-encoding; b=Pi+h81dqqkuiglevD+a2XZ4DGrMFrc7JaxKPPORnuGoLYqMXG8vdK3WJLiUvgUYQJi wkp+L+QJKiXunV53pFCLzL5b8RDJw9QR9saayJQlJ4X0Ewokf6qqnc/JkMXCEhINT/Gz hOzPURKu4mUg2eoCJ9y7HXoNCN2/S5O6R6W+M= Received: by 10.142.8.21 with SMTP id 21mr10032wfh.324.1263997561929; Wed, 20 Jan 2010 06:26:01 -0800 (PST) Received: from localhost (c-76-98-110-216.hsd1.nj.comcast.net [76.98.110.216]) by mx.google.com with ESMTPS id 21sm1458190pzk.7.2010.01.20.06.26.00 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 20 Jan 2010 06:26:01 -0800 (PST) From: Eric Sherman To: Rich Lane In-reply-to: <1263960767-sup-4706@zyrg.net> References: <1263858172-sup-547@changeling.local> <1263920054-sup-9400@zyrg.net> <1263959248-sup-4163@changeling.local> <1263960767-sup-4706@zyrg.net> Date: Wed, 20 Jan 2010 09:25:57 -0500 Message-Id: <1263997033-sup-7590@changeling.local> User-Agent: Sup/git Cc: sup-devel Subject: Re: [sup-devel] [PATCHv2] Saved Search Support X-BeenThere: sup-devel@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Sup developer discussion List-Id: Sup developer discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: sup-devel-bounces@rubyforge.org Errors-To: sup-devel-bounces@rubyforge.org Excerpts from Rich Lane's message of Wed Jan 20 01:14:46 -0500 2010: > What do you think about doing the expansion in Index.parse_query, right > after the custom-search hook? That would save you from keeping track of > the unexpanded text. Otherwise this patch looks good to me. Works for me. I hadn't even considered it, thinking the index is sacred code. Another side-effect of making this change is ParseErrors are now gracefully handled in search-list-mode where before they would have crashed sup because I wasn't thinking. Instead of returning false and flashing like in the previous patch, SearchManager#expand raises an ExpansionError, which parse_query re-raises as a ParseError. _______________________________________________ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel