From: Eric Sherman <hyperbolist@gmail.com>
To: Rich Lane <rlane@club.cc.cmu.edu>
Cc: sup-devel <sup-devel@rubyforge.org>
Subject: Re: [sup-devel] [PATCHv2] Saved Search Support
Date: Wed, 20 Jan 2010 09:25:57 -0500 [thread overview]
Message-ID: <1263997033-sup-7590@changeling.local> (raw)
In-Reply-To: <1263960767-sup-4706@zyrg.net>
Excerpts from Rich Lane's message of Wed Jan 20 01:14:46 -0500 2010:
> What do you think about doing the expansion in Index.parse_query, right
> after the custom-search hook? That would save you from keeping track of
> the unexpanded text. Otherwise this patch looks good to me.
Works for me. I hadn't even considered it, thinking the index is sacred
code.
Another side-effect of making this change is ParseErrors are now gracefully
handled in search-list-mode where before they would have crashed sup
because I wasn't thinking.
Instead of returning false and flashing like in the previous patch,
SearchManager#expand raises an ExpansionError, which parse_query re-raises
as a ParseError.
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
next prev parent reply other threads:[~2010-01-20 14:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-18 23:44 [sup-devel] [PATCH] " Eric Sherman
2010-01-19 18:00 ` Rich Lane
2010-01-20 3:46 ` Eric Sherman
2010-01-20 3:48 ` [sup-devel] [PATCHv2] " Eric Sherman
2010-01-20 6:14 ` Rich Lane
2010-01-20 14:25 ` Eric Sherman [this message]
2010-01-20 14:28 ` [sup-devel] [PATCHv3] " Eric Sherman
2010-01-23 13:01 ` William Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263997033-sup-7590@changeling.local \
--to=hyperbolist@gmail.com \
--cc=rlane@club.cc.cmu.edu \
--cc=sup-devel@rubyforge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox