From mboxrd@z Thu Jan  1 00:00:00 1970
Received: by 10.213.28.69 with SMTP id l5cs476837ebc;
        Tue, 19 Jan 2010 22:14:54 -0800 (PST)
Received: by 10.224.127.13 with SMTP id e13mr5967800qas.295.1263968093556;
        Tue, 19 Jan 2010 22:14:53 -0800 (PST)
Return-Path: <sup-devel-bounces@rubyforge.org>
Received: from rubyforge.org (rubyforge.org [205.234.109.19])
        by mx.google.com with ESMTP id 6si17135394qwk.11.2010.01.19.22.14.53;
        Tue, 19 Jan 2010 22:14:53 -0800 (PST)
Received-SPF: pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19;
Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-devel-bounces@rubyforge.org
Received: from rubyforge.org (rubyforge.org [127.0.0.1])
	by rubyforge.org (Postfix) with ESMTP id 0BADA1D788B9;
	Wed, 20 Jan 2010 01:14:53 -0500 (EST)
Received: from pion.club.cc.cmu.edu (PION.CLUB.CC.cmu.edu [128.237.157.88])
	by rubyforge.org (Postfix) with ESMTP id 9519718582CE
	for <sup-devel@rubyforge.org>; Wed, 20 Jan 2010 01:14:46 -0500 (EST)
Received: from rlane by pion.club.cc.cmu.edu with local (Exim 4.69)
	(envelope-from <rlane@zyrg.net>)
	id 1NXTq2-0003NH-4s; Wed, 20 Jan 2010 01:14:46 -0500
From: Rich Lane <rlane@club.cc.cmu.edu>
To: Eric Sherman <hyperbolist@gmail.com>
In-reply-to: <1263959248-sup-4163@changeling.local>
References: <1263858172-sup-547@changeling.local>
	<1263920054-sup-9400@zyrg.net>
	<1263959248-sup-4163@changeling.local>
Date: Wed, 20 Jan 2010 01:14:46 -0500
Message-Id: <1263960767-sup-4706@zyrg.net>
User-Agent: Sup/git
Cc: sup-devel <sup-devel@rubyforge.org>
Subject: Re: [sup-devel] [PATCHv2] Saved Search Support
X-BeenThere: sup-devel@rubyforge.org
X-Mailman-Version: 2.1.12
Precedence: list
Reply-To: Sup developer discussion <sup-devel@rubyforge.org>
List-Id: Sup developer discussion <sup-devel.rubyforge.org>
List-Unsubscribe: <http://rubyforge.org/mailman/options/sup-devel>,
	<mailto:sup-devel-request@rubyforge.org?subject=unsubscribe>
List-Archive: <http://rubyforge.org/pipermail/sup-devel>
List-Post: <mailto:sup-devel@rubyforge.org>
List-Help: <mailto:sup-devel-request@rubyforge.org?subject=help>
List-Subscribe: <http://rubyforge.org/mailman/listinfo/sup-devel>,
	<mailto:sup-devel-request@rubyforge.org?subject=subscribe>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: sup-devel-bounces@rubyforge.org
Errors-To: sup-devel-bounces@rubyforge.org

Excerpts from Eric Sherman's message of 2010-01-19 22:48:50 -0500:
> There is no nesting limit and searches are always expanded completely
> before they are turned into proper queries for the index.

What do you think about doing the expansion in Index.parse_query, right
after the custom-search hook? That would save you from keeping track of
the unexpanded text. Otherwise this patch looks good to me.
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel