From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.213.28.69 with SMTP id l5cs472607ebc; Tue, 19 Jan 2010 19:51:52 -0800 (PST) Received: by 10.224.31.146 with SMTP id y18mr5934712qac.81.1263959511088; Tue, 19 Jan 2010 19:51:51 -0800 (PST) Return-Path: Received: from rubyforge.org (rubyforge.org [205.234.109.19]) by mx.google.com with ESMTP id 6si16961322qwk.31.2010.01.19.19.51.50; Tue, 19 Jan 2010 19:51:51 -0800 (PST) Received-SPF: pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19; Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-devel-bounces@rubyforge.org; dkim=neutral (body hash did not verify) header.i=@gmail.com Received: from rubyforge.org (rubyforge.org [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id 4C08E18582DE; Tue, 19 Jan 2010 22:51:50 -0500 (EST) X-Greylist: delayed 306 seconds by postgrey-1.31 at rubyforge.org; Tue, 19 Jan 2010 22:51:45 EST Received: from mail-iw0-f195.google.com (mail-iw0-f195.google.com [209.85.223.195]) by rubyforge.org (Postfix) with ESMTP id A874D18582D5 for ; Tue, 19 Jan 2010 22:51:45 -0500 (EST) Received: by iwn33 with SMTP id 33so3837276iwn.29 for ; Tue, 19 Jan 2010 19:51:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:content-type:cc:subject:from :to:in-reply-to:references:date:message-id:user-agent :content-transfer-encoding; bh=cHijKGCaLhlekcrOEXxsECB3CwhDZG6Uc+DV9zyqX2g=; b=ru6AtVw36YVMOkKM/+WNsAW52RNXdv1yU4R6X3Li99M+x9kkfq4emVnATR/vyJhFDX f1nCjBY3tHsMsgZbDhzdgH4mIZ6q0/aTZElxun0pVxmfkuS0lHG2KRcgMCcmLn6W4Blx thZXKTNWpdk5d+WTskPa/p4f50PZ4NvuXAQPc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=content-type:cc:subject:from:to:in-reply-to:references:date :message-id:user-agent:content-transfer-encoding; b=sQwSxqHg8urdp8xTw0qqr03z6/mIf3ZAE2T9rQ49ON9F9qnLXf69k51DBOTzRLKVtS wXbCYZAjbMEtcViiCp10KHIFWkWyp3EcITrz/y275BgMGJf8cbnAIUCIIRVL3KiHolFK sIw9aUP8+bohd4TWUq9/9uQ6+ngGeWu0+Xvpo= Received: by 10.231.123.41 with SMTP id n41mr649356ibr.46.1263959198781; Tue, 19 Jan 2010 19:46:38 -0800 (PST) Received: from localhost (c-76-98-110-216.hsd1.nj.comcast.net [76.98.110.216]) by mx.google.com with ESMTPS id 23sm3597515iwn.7.2010.01.19.19.46.37 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 19 Jan 2010 19:46:37 -0800 (PST) From: Eric Sherman To: Rich Lane In-reply-to: <1263920054-sup-9400@zyrg.net> References: <1263858172-sup-547@changeling.local> <1263920054-sup-9400@zyrg.net> Date: Tue, 19 Jan 2010 22:46:35 -0500 Message-Id: <1263959057-sup-3237@changeling.local> User-Agent: Sup/git Cc: sup-devel Subject: Re: [sup-devel] [PATCH] Saved Search Support X-BeenThere: sup-devel@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Sup developer discussion List-Id: Sup developer discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: sup-devel-bounces@rubyforge.org Errors-To: sup-devel-bounces@rubyforge.org Excerpts from Rich Lane's message of Tue Jan 19 13:00:32 -0500 2010: > I'd like it better if shrinking went away and the only time we expanded > was right before giving it to parse_query. I'd rather not have the > expand-on-delete or rename-tracking behaviors. I'm not sure why I thought any of that was such a great idea. > I think attempting to expand a nonexistent saved search should result in > something false ("type:false", maybe), send a warning to the log, and > perhaps flash an error message. SearchManager#expand now returns false, logs a warning and flashes an error message when expansion fails. > On Ruby 1.9.1 I get: > lib/sup/search.rb:69: warning: Hash#index is deprecated; use Hash#key Removed. > SearchListMode#regen_text: looks like a mixup of each and map Fixed. > SearchListMode#add_new_search: > Should flash an error message on name collisions, or allow overwriting. > > SearchListMode#rename_selected_search, SearchListMode#save_search: > Name collision handling should be consistent with add_new_search. An error message is flashed. > SearchManager: > I'd replace the duplicated name checking regexes with a method. Replaced. > SearchManager#rename: > I think the strip should be done by the caller. Done. _______________________________________________ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel