From: Eric Sherman <hyperbolist@gmail.com>
To: Rich Lane <rlane@club.cc.cmu.edu>
Cc: sup-devel <sup-devel@rubyforge.org>
Subject: Re: [sup-devel] [PATCH] Saved Search Support
Date: Tue, 19 Jan 2010 22:46:35 -0500 [thread overview]
Message-ID: <1263959057-sup-3237@changeling.local> (raw)
In-Reply-To: <1263920054-sup-9400@zyrg.net>
Excerpts from Rich Lane's message of Tue Jan 19 13:00:32 -0500 2010:
> I'd like it better if shrinking went away and the only time we expanded
> was right before giving it to parse_query. I'd rather not have the
> expand-on-delete or rename-tracking behaviors.
I'm not sure why I thought any of that was such a great idea.
> I think attempting to expand a nonexistent saved search should result in
> something false ("type:false", maybe), send a warning to the log, and
> perhaps flash an error message.
SearchManager#expand now returns false, logs a warning and flashes an error
message when expansion fails.
> On Ruby 1.9.1 I get:
> lib/sup/search.rb:69: warning: Hash#index is deprecated; use Hash#key
Removed.
> SearchListMode#regen_text: looks like a mixup of each and map
Fixed.
> SearchListMode#add_new_search:
> Should flash an error message on name collisions, or allow overwriting.
>
> SearchListMode#rename_selected_search, SearchListMode#save_search:
> Name collision handling should be consistent with add_new_search.
An error message is flashed.
> SearchManager:
> I'd replace the duplicated name checking regexes with a method.
Replaced.
> SearchManager#rename:
> I think the strip should be done by the caller.
Done.
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
next prev parent reply other threads:[~2010-01-20 3:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-18 23:44 Eric Sherman
2010-01-19 18:00 ` Rich Lane
2010-01-20 3:46 ` Eric Sherman [this message]
2010-01-20 3:48 ` [sup-devel] [PATCHv2] " Eric Sherman
2010-01-20 6:14 ` Rich Lane
2010-01-20 14:25 ` Eric Sherman
2010-01-20 14:28 ` [sup-devel] [PATCHv3] " Eric Sherman
2010-01-23 13:01 ` William Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263959057-sup-3237@changeling.local \
--to=hyperbolist@gmail.com \
--cc=rlane@club.cc.cmu.edu \
--cc=sup-devel@rubyforge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox